-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for capacity unit reservation for load balancers #3950
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shraddhabang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since migration of GO SDK to V2, we dont need to generate the private SDK from model anymore. You can simple download the generated GoV2 SDK code and replace references directly.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@shraddhabang: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Application Load Balancer (ALB) and Network Load Balancer (NLB) now support Load Balancer Capacity Unit (LCU) Reservation that allows you to proactively set a minimum capacity for your load balancer, complementing its existing ability to auto-scale based on your traffic pattern. Ref : https://aws.amazon.com/about-aws/whats-new/2024/11/load-balancer-capacity-unit-reservation-application-balancers/
Adding support for this feature on controller for Ingress and Services.
Customer Experience
End user will need to update the controller to the latest version containing this feature. They will also need to update the IAM policies and IngressClassParam CRDs after updating the controller version to use this feature.
Default mode
If the alb.ingress.kubernetes.io/minimum-load-balancer-capacity or service.beta.kubernetes.io/aws-load-balancer-minimum-load-balancer-capacity annotations are not specified for the ingress or service in the manifest, the capacity will be set to zero on the new load balancers by default.
Update capacity :
If the end user wants to update the capacity for ALB/NLB to 1200 capacity units, they can update it by setting the new annotation as follows
Sets the minimum capacity for the ALB
alb.ingress.kubernetes.io/minimum-load-balancer-capacity: CapacityUnits=1200
Sets the minimum capacity for the NLB
service.beta.kubernetes.io/aws-load-balancer-minimum-load-balancer-capacity: CapacityUnits=1200
Reset capacity:
If the end user wants to reset the capacity back to 0, they can either remove the new annotations or they can set the capacity on the annotations to be zero as follows
Sets the minimum capacity for the ALB
alb.ingress.kubernetes.io/minimum-load-balancer-capacity: CapacityUnits=0
Sets the minimum capacity for the NLB
service.beta.kubernetes.io/aws-load-balancer-minimum-load-balancer-capacity: CapacityUnits=0
Turn off feature flag for capacity reservation (New)
If the customer wants to disable this feature to avoid accidental capacity reservation, then they can turn this feature off through the controller flag by updating their controller deployment as follows
Increase the stabilization requeue interval(New)
If the customer wants to increase the interval to monitor the LB status, then they can set through the controller flag by updating their controller deployment as follows
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯