-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[helm chart] add resource-policy annotations to crds #3918
base: main
Are you sure you want to change the base?
[helm chart] add resource-policy annotations to crds #3918
Conversation
Signed-off-by: adam_buran <adam.buran@airbnb.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aburan28 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @aburan28. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Anyone able to review this PR? It is a fairly simple change |
Issue
Guidance on upgrades for AWS LB controller includes references to uninstalling the old version before moving to the new version of the controller. In those cases it would be ideal if we could retain the CRDs during that uninstall so as to prevent downtime associated with a fresh install.
Description
CRDs are deleted by default when the helm chart is uninstalled. Offering an option to retain those resources would be great. Addittionally it would be ideal to pass in annotations to the CRDs.
In this PR I've added the following section which allow for configuring whether or not the helm
"helm.sh/resource-policy": keep
annotation is added to the CRDs, whether or not the CRDs are installed, and additional annotations that could be passed into the CRDs.Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯