Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm chart] add resource-policy annotations to crds #3918

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aburan28
Copy link

@aburan28 aburan28 commented Oct 29, 2024

Issue

Guidance on upgrades for AWS LB controller includes references to uninstalling the old version before moving to the new version of the controller. In those cases it would be ideal if we could retain the CRDs during that uninstall so as to prevent downtime associated with a fresh install.

Description

CRDs are deleted by default when the helm chart is uninstalled. Offering an option to retain those resources would be great. Addittionally it would be ideal to pass in annotations to the CRDs.

In this PR I've added the following section which allow for configuring whether or not the helm "helm.sh/resource-policy": keep annotation is added to the CRDs, whether or not the CRDs are installed, and additional annotations that could be passed into the CRDs.

crds:
  keep: false
  install: true
  annotation: {}

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Signed-off-by: adam_buran <adam.buran@airbnb.com>
Copy link

linux-foundation-easycla bot commented Oct 29, 2024

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aburan28
Once this PR has been reviewed and has the lgtm label, please assign m00nf1sh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 29, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @aburan28. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 29, 2024
@aburan28 aburan28 changed the title add resource-policy annotations to crds [helm chart] add resource-policy annotations to crds Oct 29, 2024
@aburan28
Copy link
Author

Anyone able to review this PR? It is a fairly simple change

Signed-off-by: Adam Buran <aburan28@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants