Avoid flooding error logs from kubelet_stats_summary collector #1222
Conversation
k8s-ci-robot
added
the
kind/cleanup
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tydra-wang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
| @@ -90,7 +90,8 @@ func (c *kubeletStatsSummaryCollector) Update(ch chan<- prometheus.Metric) error | |||
| defer resp.Body.Close() | |||
| if resp.StatusCode != http.StatusOK { | |||
| body, _ := io.ReadAll(resp.Body) | |||
| return fmt.Errorf("failed to get kubelet stats summary: %d: %q", resp.StatusCode, string(body)) | |||
| klog.V(4).InfoS("Failed to get kubelet stats summary", "status_code", resp.StatusCode, "body", string(body)) | |||
There was a problem hiding this comment.
Should the klog level be set to 2 to prevent excessive logging of infos?
There was a problem hiding this comment.
v=2 is the default level set in helm.
I think this is not the correct way to hide the error. Maybe we should add a flag to disable this collector completely?
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: