disk: block for 1s when conflicting #1190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huww98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
huww98
force-pushed
the
disk-detach-errcode
branch
from
ddb887d
to
78cd26a
Compare
k8s-ci-robot
added
size/M
Only 5 concurrent detach is allowed by ECS. So limit that at our side to avoid too many conflicts.
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
Delay the response is not ideal (for potential timeout, especially combined with #1218), maybe we should find another way. |
If we receive certain error from ECS, we can block retry this node for some time, to avoid too much useless OpenAPI call.
Avoid too much useless retry when conflicting. Return success when already detached.
to avoid too many useless requests
huww98
force-pushed
the
disk-detach-errcode
branch
from
78cd26a
to
b241427
Compare
k8s-ci-robot
added
size/L
|
based on #1216 , so merge after it. |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
huww98
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Avoid too much useless retry when conflicting.
Return success when already detached.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: