-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change examples/dynamic-client creation of DynamicClient to include configuration object that is not None #2283
base: master
Are you sure you want to change the base?
Conversation
Changed the examples to showcase DynamicClient instantiation without the parameter since `config.load_kube_config()` does not return anything. Signed-off-by: Christoffer Kragh Pedersen <ckp@kragh.dev>
The committers listed above are authorized under a signed CLA. |
Welcome @tonur! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tonur The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @fabianvf |
This is currently not working, I am at a loss for words on why. I will try to dive into the |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Changed the examples to showcase DynamicClient instantiation without the parameter since
config.load_kube_config()
does not return anything. See more about this in #2279.Which issue(s) this PR fixes:
Fixes #2279
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: