Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device slot improvements #75

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Device slot improvements #75

wants to merge 26 commits into from

Conversation

exinfinitum
Copy link
Contributor

@exinfinitum exinfinitum commented Mar 27, 2021 •
edited
Loading

  • Add ability to install devices to device slots by ID
  • Enable "force install to device slot" option in shpInstallDevice objCanInstallItem to check installation of items to device slots taking into account criteria, maxMass, maxPower, maxPowerPercentage fields and prevent installation if these conditions are not met (also allow installation into unoccupied device slots)
  • Add similar checks to shpCanInstallDevice
  • Add description, attributes, maxMass, maxPower and maxPowerPercentage fields to deviceSlots
  • Add new options to objGetProperty to enable getting device slot info

@exinfinitum
Copy link
Contributor Author

exinfinitum commented Apr 29, 2021 •
edited
Loading

Implementing targetCriteria support will be quite a bit more complicated. We may want to leave that as well as the ability to specify targetCriteria in weapon xml definitions to another PR, and just merge the current feature set as is for this PR.

@exinfinitum exinfinitum marked this pull request as ready for review May 6, 2021 22:13
@exinfinitum exinfinitum marked this pull request as draft June 6, 2021 19:47
@exinfinitum
Copy link
Contributor Author

TODO: Remove force install to device slot for shpInstallDevice. Do not remove this argument from objCanInstallItem.

@exinfinitum exinfinitum changed the title [WIP] Device slot improvements Device slot improvements Jun 6, 2021
@exinfinitum exinfinitum marked this pull request as ready for review June 7, 2021 05:32
@exinfinitum
Copy link
Contributor Author

TODO: Fix exception when accessing device at slot for ships with devices assigned to specific slot IDs.

@exinfinitum exinfinitum marked this pull request as draft November 12, 2021 07:10
exinfinitum
exinfinitum commented Nov 13, 2021
View reviewed changes
Mammoth/TSE/ShipProperties.cpp Outdated Show resolved Hide resolved
Mammoth/TSE/Devices.cpp Outdated Show resolved Hide resolved
Mammoth/TSE/CSpaceObject.cpp Outdated Show resolved Hide resolved
Mammoth/TSE/CDeviceSystem.cpp Outdated Show resolved Hide resolved
@exinfinitum exinfinitum marked this pull request as ready for review November 13, 2021 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@exinfinitum