Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate kubernetes functions in favor of krkn-lib #727

Open
paigerube14 opened this issue Oct 30, 2024 · 4 comments
Open

Remove duplicate kubernetes functions in favor of krkn-lib #727

paigerube14 opened this issue Oct 30, 2024 · 4 comments

Comments

@paigerube14
Copy link
Collaborator

While working on adding the ability to connect to private clusters (Pr), I found that I would have to add the same set of changes in 5+ places because of the current implementation of the "native" scenarios. This is because each of the native scenarios defines its own set of connection and functions to a set cluster (example: pod_network_scenario)
I think that we should remove the kubernetes functions that are duplicately defined in krkn and instead use the same configuration that is defined in krkn-lib. This will help align the connection type and reduce the duplication of functions. I think it will also reduce the ease of adding new scenarios if we have one common place with all functions and libraries for interacting with the kubernetes cluster

@Josecespedesant
Copy link

Hello @paigerube14 I recently found krkn and was looking for ways to help, I came across this issue and started looking through the code a bit to understand the context of it. Just to see if I understood it correctly, the idea would be to remove from the native scenarios (let's say the node_scenarios) the whole file of kubernetes_functions.py and instead use an instance of KrknKubernetes throughout the plugins accordingly?

@paigerube14
Copy link
Collaborator Author

@Josecespedesant Awesome! We love any contributions we can get!
Yes exactly, if any functions are missing feel free to also add them to krkn-lib as needed. This might also require some rework in the general set up the scenario. But overall should align with other node scenarios like this and this scenario file
Let us know if you need any other help and we would be happy to review any draft PR's as you start working. Thanks for your contributions

@Josecespedesant
Copy link

Great! Really appreciated! I also joined the krkn channel in Slack, is that a good way to communicate with the team as well?

@paigerube14
Copy link
Collaborator Author

@Josecespedesant yes! thats a great way to reach us as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants