Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword part of Readme about sanity checks #10

Open
krayzpipes opened this issue May 22, 2019 · 0 comments
Open

Reword part of Readme about sanity checks #10

krayzpipes opened this issue May 22, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@krayzpipes
Copy link
Owner

This just sounds bad:

Sanity:
This is the algorithm to use with this filter in order to validate the data is really what you're looking for. For example, 16 digits might just be a random number and not a credit card. Putting the numbers through the luhn algorithm will validate they could potentially be an account number and reduce false positives.
You can also pass through a list of strings that represent algorithms as long as the algorithm exists in the library. If not, please add it and make a pull request!

@krayzpipes krayzpipes added the enhancement New feature or request label May 22, 2019
@krayzpipes krayzpipes added the good first issue Good for newcomers label Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant