Added support for binary update with TWRP

[x3rAx]

When trying to update the su binary with a TeamWin Recovery installed, the phone rebooted into recovery but the binary was not updatet.
This fixes issue #216. The su binary is now also updated via TWRP.

[koush]

/cache/recovery/command is AOSP's update mechanism, and is also what CM uses. TWRP doesn't support this?

[x3rAx]

Well, seems like TWRP wants to have /cache/recovery/openrecoveryscript as described here: http://www.teamw.in/OpenRecoveryScript

[x3rAx]

I wondered why TWRP doesn't support /cache/recovery/command when it's AOSP standard and after a quick search I found this line inside the TWRP repository. As I see this, I'd assume this should work but it does not for me.

The command file is read here but only if argc contains elements.. But I don't know if it is somehow possible to start recovery with arguments..

Or am I missing something?

[koush]

That's just the regular AOSP code and it should work. Not sure why it is not working. Can you pull a log of recovery after it reboots?

[x3rAx]

I found something interesting in the log:

[...]
I:Got arguments from /cache/recovery/command
E:Cannot load volume /misc!
Startup Commands:  '--update_package=CACHE:superuser.zip'ro.qc.sdk.audio.
[...]

and later

[...]
I:Inserting 'install CACHE:superuser.zip'
I:Copying file /cache/recovery/log to /cache/recovery/last_log
I:Attempt to load settings from settings file...
I:Loading settings from '/data/media/0/TWRP/.twrps'.
I:Backup folder set to '/data/media/0/TWRP/BACKUPS/SH35EW901904'
I:Copying file /etc/recovery.fstab to /cache/recovery/recovery.fstab
I:Version number saved to '/cache/recovery/.version'
I:Mount: Unable to find partition for path '/external_sd'
__bionic_open_tzdata: couldn't find any tzdata when looking for NFT-1DFT!
__bionic_open_tzdata: couldn't find any tzdata when looking for posixrules!
I:Switching packages (TWRP)
I:Set page: 'action_page'
Processing AOSP recovery commands...
I:command is: 'install' and I:value is: 'CACHE:superuser.zip'
I:Unable to mount '/usb-otg'
I:Actual block device: '', current file system: 'vfat'
I:Unable to mount '/usb-otg'
I:Actual block device: '', current file system: 'vfat'
I:Full zip path: '/data/media/0/CACHE:superuser.zip'
I:Zip file not found on external storage, trying internal...
I:Backup folder set to '/data/media/0/TWRP/BACKUPS/SH35EW901904'
I:Full zip path: '/data/media/0/CACHE:superuser.zip'
Unable to locate zip file '/data/media/0/CACHE:superuser.zip'.
E:Error installing zip file '/data/media/0/CACHE:superuser.zip'
Done processing script file
[...]

Obviously CACHE:superuser.zip is not translated to /cache/superuser.zip...

What's the purpose of using CACHE: instead of /cache?

[rvdaa92]

Any progress on this? I want to update, but i just cant.. (also using htc one with twrp)

[ceilfors]

@rvdaa92 I manually flashed the zip for the update. Details can be found here

[x3rAx]

Workaround:

As a workaround you could also try updating it through the app and after your phone rebooted to recovery without flashing the new version, you could manually flash '/cache/superuser.zip'

[zaaraameera2014]

Mmmmmmm