Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip checksum advanced option #5

Open
boktai1000 opened this issue Sep 3, 2024 · 1 comment
Open

Add skip checksum advanced option #5

boktai1000 opened this issue Sep 3, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@boktai1000
Copy link

Unfortunately, some patches aren't created properly and still work - and as an advanced option it would be nice to allow the patcher to force continue as it is expected to apply the patch even though the creator did something incorrectly. Perhaps hide the option, make it an advanced option or something like that. Example below.

Error occurred while patching
Details: target window checksum mismatch (code -17712)

image

@kotcrab
Copy link
Owner

kotcrab commented Sep 3, 2024

I don't think it's a problem with the patch, rather you're trying to apply it to a different source file. Still, I guess it's true it might work for some cases. We can add it similar as they did here. That is: try to patch as usual, if that fails with checksum error then show some option/button to retry with checksum disabled.

@kotcrab kotcrab added the enhancement New feature or request label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants