fix: published_at being set even if published: true already set
#392
+45
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #310 Prevent setting `published_at` when `published: true` is already set. * **src/functions.ts** - Update `updateZennMetadata` to exclude `published_at` when `published: true`. - Add a check to skip updating `published_at` if `published: true` is already set. * **src/__tests__/main.test.ts** - Add a test to verify `published_at` is not set when `published: true`. - Update existing test to include `published: true` and verify `published_at` is updated only when `published: false`. * **.devcontainer.json** - Add a devcontainer configuration file with a test task. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/korosuke613/zenn-metadata-updater-action/issues/310?shareId=XXXX-XXXX-XXXX-XXXX).
korosuke613
force-pushed
the
fix-published-at
branch
from
44005ef
to
441368f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #310
Prevent setting
published_atwhenpublished: trueis already set.updateZennMetadatato excludepublished_atwhenpublished: true.published_atifpublished: trueis already set.published_atis not set whenpublished: true.published: trueand verifypublished_atis updated only whenpublished: false.For more details, open the Copilot Workspace session.