Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fabfile.py has gotten crufty #179

Open
divergentdave opened this issue Mar 12, 2017 · 2 comments
Open

fabfile.py has gotten crufty #179

divergentdave opened this issue Mar 12, 2017 · 2 comments

Comments

@divergentdave
Copy link
Collaborator

divergentdave commented Mar 12, 2017

The current state of the fabfile doesn't totally make sense right now, because the scrapers and web server are now on different servers, and other changes. We haven't touched the frontend in quite a while, so it hasn't come up yet.

  • Currently the fabfile will log in to every web server. Either there's just one web server, so that makes sense, or there's a production server and a staging server, in which case that isn't very useful.
  • The reindex function won't work anymore, because it would be run on the scraper, which doesn't have the data EBS volume mounted. If we can have different fabric commands target different servers, this would be a good place to do so.
  • It might make sense to drop the "cold" variants of commands, since the user-data scripts currently start up servers with forever, so there's no cold start to be done.
  • By rights, there ought to be a call to rake elasticsearch:init_dashboard, either under reindex or somewhere else.
@konklone
Copy link
Owner

Should we just delete it entirely? How are you running deploys at the moment?

@divergentdave
Copy link
Collaborator Author

All deploys in recent memory have been scrapers only or infrastructure related, not frontend, so I've been using the webhook to update scrapers and spinning up fresh servers when that's needed. I think it's worth keeping around for the next time there's frontend work to deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants