Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme based on cover not working with black-white cover #545

Open
7 tasks done
l2eused opened this issue Nov 19, 2024 · 6 comments
Open
7 tasks done

theme based on cover not working with black-white cover #545

l2eused opened this issue Nov 19, 2024 · 6 comments

Comments

@l2eused
Copy link

l2eused commented Nov 19, 2024

Steps to reproduce

  1. enable Theme based on cover option (appearance > manga info)
  2. open any entries with black-white cover (cover that only contains black or white color/gray scale) - I tried with any bw cover doujins
  3. see the color change based on cover

Expected behavior

should using black/white color as theme based on cover

Actual behavior

app will using user theme instead (in my case, app using light blue same as my dynamic color theme)

Crash logs

No response

Komikku version

1.12.1-9577

Android version

Android 14

Device

Xiaomi 14 (houji)

Other details

I'm not sure if this bugs or not, I still suggest this fix after all.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • If this is an issue with an official extension, I should be opening an issue in the extensions repository.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 1.12.1.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@cuong-tran
Copy link
Collaborator

Yeah. What color do we expect with black/white cover?

@cuong-tran
Copy link
Collaborator

I don't think a black/white theme is something we would like to see?

@l2eused
Copy link
Author

l2eused commented Nov 19, 2024

I don't think a black/white theme is something we would like to see?

I still prefer black/white color as they should be over the app theme tbh.

In some entries for example: 346485 (nh id), we know that is color like orange/brown tone but app using dynamic color (blue in my case) because (I think) it detect the white text. That's really weird with orange and blue combination.

@cuong-tran
Copy link
Collaborator

I don't think a black/white theme is something we would like to see?

I still prefer black/white color as they should be over the app theme tbh.

In some entries for example: 346485 (nh id), we know that is color like orange/brown tone but app using dynamic color (blue in my case) because (I think) it detect the white text. That's really weird with orange and blue combination.

Could you provide some screenshot?

@l2eused
Copy link
Author

l2eused commented Nov 19, 2024

Contents warning!! NSFW

this example showing ugly color compare with cover image

Screenshot_2024-11-20-00-55-20-335_app.komikku.beta-edit.jpg


these examples showing entries that seem like using white theme already (maybe a little color but my eyes didn't see different from white color)

Since these one already contains white color, I don't think there is much problem if using black/white in non-color cover entries in my opinion

Screenshot_2024-11-20-00-54-59-825_app.komikku.beta.jpg

Screenshot_2024-11-20-00-56-01-399_app.komikku.beta-edit.jpg

Screenshot_2024-11-20-00-57-18-613_app.komikku.beta-edit.jpg

@l2eused
Copy link
Author

l2eused commented Nov 19, 2024

these examples showing entries that seem like using white theme already (maybe a little color but my eyes didn't see different from white color)

Since these one already contains white color, I don't think there is much problem if using black/white in non-color cover entries in my opinion

overall, should be better than my dynamic color that not make sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants