Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMB password revealed in debug log #74

Open
dmittiga opened this issue Nov 14, 2019 · 0 comments
Open

SMB password revealed in debug log #74

dmittiga opened this issue Nov 14, 2019 · 0 comments

Comments

@dmittiga
Copy link

With debugging logging enabled, the add-on reveals the SMB password when issuing the StreamStartError message. When logging the OpenRecordedStream or OpenLiveStream event, a password safe version of the SMB string is used when available. But later in each method, if the stream fails to open, a StreamStartError message is sent using the unsafe SMB string, revealing the password.

pvr2wmc.cpp lines 1314 and 1577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmittiga