Set projects' working directories to use the current path. #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srmeier
approved these changes
Nov 11, 2024
GiRx8
approved these changes
Nov 11, 2024
This change ensures assets load relative to the current path, improving application portability. Additionally, simplified some uses of `GetCurrentDirectory` WinAPI by replacing it with `std::filesystem::current_path`.
stevewgr
force-pushed
the
fix-workdir
branch
from
309a6ac
to
87e1cfd
Compare
|
Build passing: https://github.com/ko4life-net/ko/actions/runs/11789453965/job/32838241357 Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates projects' to set the working directory to the current path, enhancing portability and consistency in asset loading.
GetCurrentDirectory(WinAPI) withstd::filesystem::current_pathin several instances to simplify code and leverage standard library functionality.