Use SrcDir and absolute paths for improved build reliability and portability. #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolutionDir can be problematic when building a specific project directly, as it is undefined when passing a vcxproj file to msbuild instead of a sln file. This change improves portability by making the build process more resilient to directory relocations.
This change improves project maintenance and enhances resilience to directory relocations by standardizing paths with the SrcDir variable.
|
Build passing: https://github.com/ko4life-net/ko/actions/runs/10278200148/job/28441471408 Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes two key changes aimed at improving project maintainability and robustness:
Use SrcDir Instead of SolutionDir:
SolutionDirvariable with theSrcDirvariable.SolutionDirvariable can be problematic when building a specific project directly, especially when passing a.vcxprojfile tomsbuildinstead of a.slnfile. In such cases,SolutionDiris undefined and can break the build.SrcDirmakes the project more portable and resilient to directory relocations.Replace Relative Paths with Absolute Paths Using SrcDir:
SrcDirvariable.Benefits
SolutionDirvariable, builds are more consistent and less prone to failures when using different project files.SrcDirmake the project structure more robust and adaptable to changes in directory locations.