Fix gitattributes file to treat *.rc & *.rc2 files as text #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ensured all affected files are renormalized within the same commit due to issues described in here: git-for-windows/git#5078 (comment)
|
Build passing without any issues 🎉: https://github.com/ko4life-net/ko/actions/runs/10225794695/job/28295256832 Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves: #243
Note that the bug in git's code triggers when adding the gitattributes configurations in an individual commit. The changes of gitattributes and renormalization of the affected files must occur within the same commit when modifying the .gitattributes file as described here: git-for-windows/git#5078 (comment)
Moving forward any changes to
*.rcand*.rc2files should properly render the diffs.Also I explictly set some files as binary in the gitattributes file to hint git to not touch them when checking out files in the git's worktree or git index.