Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider re-integrating PyARPES #21

Open
kmnhan opened this issue Apr 15, 2024 · 0 comments
Open

Consider re-integrating PyARPES #21

kmnhan opened this issue Apr 15, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@kmnhan
Copy link
Owner

kmnhan commented Apr 15, 2024

PyARPES seems to be unmaintained: chstan/arpes#23
But has a maintained fork! chstan/arpes#23 (comment)

Although we moved away from PyARPES functionality and are happy, maybe we could consider re-adding compatibility layers since they have many more data plugins...

Options:

  • Discard our data model, roll back to PyARPES conventions
    • Pros: we get access to data loaded by PyARPES data loaders!
    • Cons: I personally dislike a lot of things about their data convention like angle notation and attribute mangling, our momentum conversion will need major fixes
  • Write a conversion function that transforms PyARPES data format to match ours
    • This should be easy since PyARPES format is very constrained
    • However the other way around will be quite hard
    • And duplicated loader functionality is chaos
  • Write a compatibility layer that subclasses a PyARPES loader and BaseLoader (multiple inheritance)
    • Use PyARPES loaders with our syntax!
    • Is this even possible?
  • Ignore PyARPES and move on
    • The easiest way
    • However majority of attempts to analyze ARPES data with python are concentrated in PyARPES, could it become standard in the future?
    • We have to implement more data loaders for this to not be a problem
@kmnhan kmnhan added the enhancement New feature or request label Apr 15, 2024
@kmnhan kmnhan self-assigned this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant