Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHNL-14635] Fetch Full Forms #197

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

dan-peluso
Copy link
Contributor

Description

  • adding new request for 'full-forms' and logging the response

A few things to consider

  • This response will be going to the klaviyo.js loadData() call, so we don't need to serialize more than the top 3 fields here (and probably wouldn't want to given how we don't care about the details)
  • For now we're using the web forms endpoint, so we have to take only the first item on the list of forms
  • We still need to define that function in the klaviyo.js updates, so for now this PR is just creating the request and logging with some basic serialization, I will integrate once klaviyo.js gets updated

Check List

  • Are you changing anything with the public API?
  • Are your changes backwards compatible with previous SDK Versions?
  • Have you tested this change on real device?
  • Have you added unit test coverage for your changes?
  • Have you verified that your changes are compatible with all Android versions the SDK currently supports?

Changelog / Code Overview

Test Plan

Related Issues/Tickets

CHNL-14635

@dan-peluso dan-peluso requested a review from a team as a code owner November 8, 2024 22:45
@dan-peluso dan-peluso requested review from njparadis and removed request for a team November 8, 2024 22:45
Copy link

@njparadis njparadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question around the shape of the response from the API. Do you think we need any tests around that stuff? Logic seems straightforward enough to me but maybe an example response would be helpful documentation for our future selves 👍

@dan-peluso
Copy link
Contributor Author

LGTM, just one question around the shape of the response from the API. Do you think we need any tests around that stuff? Logic seems straightforward enough to me but maybe an example response would be helpful documentation for our future selves 👍

I was planning to add those once we have more stucture defined around what we actually do with that response. For now since we can't really pass it to klaviyo.js I figured this ticket can be limited to setting up the new request type and creating some of the infrastructure for when we do need to format for passing to klaviyo.js

@dan-peluso dan-peluso merged commit 1827dc2 into feature/IAM Nov 19, 2024
6 checks passed
@dan-peluso dan-peluso deleted the dan/CHNL-14635-fetch-full-forms-from-endpoint branch November 19, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants