Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: test util in indexer to generate Starknet calldata #1417

Open
tcoratger opened this issue Sep 30, 2024 · 3 comments
Open

dev: test util in indexer to generate Starknet calldata #1417

tcoratger opened this issue Sep 30, 2024 · 3 comments
Labels
enhancement Enhancement of the code, not introducing new features.

Comments

@tcoratger
Copy link
Collaborator

Description

In our Typescript indexer, we should introduce a utility function that generates random StarkNet calldata, providing a comprehensible implementation for each element of the array.

Currently, all the tests passes, but it's difficult to understand how the calldata is constructed and whether it is correct or not. The goal is to make this process more transparent and accessible.

Expected Feature

We need a function that:

  • Accepts key parameters (e.g., to, etc.).
  • Returns clean, well-documented calldata.
  • Makes it easy for developers, including first-time contributors, to generate test calldata confidently.

By having a clear and reusable utility function, we can ensure that the test cases are easier to understand, and contributors can generate calldata reliably without needing deep knowledge of the internals.

Additional Context

This utility function will help improve the clarity of the test suite, making it easier for developers to construct valid calldata and reducing the potential for errors.

We should replace the existing test calldatas by call to this function.

Related #1414 (comment)

@tcoratger tcoratger added the enhancement Enhancement of the code, not introducing new features. label Sep 30, 2024
@Eikix
Copy link
Member

Eikix commented Oct 24, 2024

What is the status of this?
Including it in your next Tech strategizing workshop with @ClementWalter

@Eikix Eikix moved this from 🆕 Backlog to 📅 Next sprint in Kakarot's Project Management Oct 24, 2024
@Eikix
Copy link
Member

Eikix commented Nov 5, 2024

What is the status of this @tcoratger

@tcoratger
Copy link
Collaborator Author

Not prio right now since this is just "a nice improvement" and not something we absolutely need right now. Will spend more time on it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
Status: 🆕 Backlog
Development

No branches or pull requests

2 participants