Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump hive testing to the latest execution API #1049

Open
greged93 opened this issue May 3, 2024 · 7 comments
Open

feat: bump hive testing to the latest execution API #1049

greged93 opened this issue May 3, 2024 · 7 comments
Labels
blocked Blocked right now for external reasons ci Work that improves the continuous integration. testing Improve or add testing to the codebase

Comments

@greged93
Copy link
Contributor

greged93 commented May 3, 2024

Feature Request

In order to benefit from the latest tests from the execution-apis tests, we would want to bump this to the latest commit on our hive fork.

However, the chain id for the hive tests has been updated since this commit. Because of an ongoing issue on Katana which involves blockifier, we can't bump to this commit which would highly benefit us, given the fact that multiple additional routes were added for testing (e.g. get_logs).

This issue is raised for tracking.

@greged93 greged93 added ci Work that improves the continuous integration. blocked Blocked right now for external reasons testing Improve or add testing to the codebase labels May 3, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet May 3, 2024
@greged93
Copy link
Contributor Author

This issue is fixed in the latest version of blockifier, so we could update hive to the latest version and try it out.

@greged93 greged93 removed the blocked Blocked right now for external reasons label Jul 23, 2024
@greged93 greged93 self-assigned this Aug 7, 2024
@greged93 greged93 moved this from 🆕 Backlog to 🔖 Ready in Kakarot on Starknet Aug 7, 2024
@greged93 greged93 added the blocked Blocked right now for external reasons label Aug 8, 2024
@greged93 greged93 moved this from 🔖 Ready to 🛑 Blocked in Kakarot on Starknet Aug 8, 2024
@Eikix
Copy link
Member

Eikix commented Oct 2, 2024

What is the status of this?

@greged93
Copy link
Contributor Author

greged93 commented Oct 2, 2024

same as before, blocked by blockifier

@Eikix
Copy link
Member

Eikix commented Oct 2, 2024

same as before, blocked by blockifier

What is the ETA / the precise blocker?
Can we track the issue on the new blockifier repo?

@greged93
Copy link
Contributor Author

greged93 commented Oct 2, 2024

the exact issue is described in the issue on Katana mentioned in the issue itself. (dojoengine/dojo#1595)

@Eikix
Copy link
Member

Eikix commented Oct 22, 2024

Cc'ing @ClementWalter
Context: we use a fork of hive because some standard EVM characteristics are not suitable for us (e.g. BlockHash computation) -> commenting out some part of tests.
Problem: our fork is too outdated (>6months) -> painful and bad overall
As part of our test framework stability and reducing "fork hell", we ideally want to bump hive fork

We're blocked by a silly chainID problem stemming from blockifier.
We need to have an action plan to fix this in the next atelier tech

@greged93 greged93 removed their assignment Oct 24, 2024
@greged93 greged93 moved this from 📅 Next sprint to 🆕 Backlog in Kakarot on Starknet Oct 24, 2024
@Eikix
Copy link
Member

Eikix commented Oct 24, 2024

Are we still blocked for this? I think Kari from Dojo just fixed this problem in latest katana PR: dojoengine/dojo#2276

Let's monitor when it is merged.
⚠️ Note the next bump of Katana will require us to change default Katana signer PK in Kakarot and Kakarot RPC

@Eikix Eikix moved this from 🆕 Backlog to 📅 Next sprint in Kakarot on Starknet Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked right now for external reasons ci Work that improves the continuous integration. testing Improve or add testing to the codebase
Projects
No open projects
Status: 🆕 Backlog
Development

No branches or pull requests

2 participants