Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iPhone video starts with a black screen #916

Closed
BPerlakiH opened this issue Aug 5, 2024 · 14 comments · Fixed by #924
Closed

iPhone video starts with a black screen #916

BPerlakiH opened this issue Aug 5, 2024 · 14 comments · Fixed by #924
Assignees
@BPerlakiH
Labels
bug iOS
Milestone
3.5.0

Comments

@BPerlakiH
Copy link
Collaborator

BPerlakiH commented Aug 5, 2024 •
edited
Loading

After pressing play, the video starts in full screen, but the screen is black.
If we close full screen and go fullscreen again or toggle it via picture in picture it works fine. These steps need to be repeated for each video, even if they are on the same “tab”.

Content used (currently in the "New" section):
@BPerlakiH BPerlakiH self-assigned this Aug 5, 2024
@kelson42 kelson42 added this to the 3.5.0 milestone Aug 5, 2024
@BPerlakiH BPerlakiH mentioned this issue Aug 8, 2024
Merged
@BPerlakiH BPerlakiH linked a pull request Aug 8, 2024 that will close this issue
Fix iPhone video starting with a black screen on iOS 17 iPhone #924
Merged
@kelson42
Copy link
Contributor

kelson42 commented Aug 11, 2024 •
edited
Loading

There is in your report two bugs: the black screen AND the fullscreen. But I can not reproduce this bug with iPadOS on iOS18. What are the exact reproduction steps?

@BPerlakiH
Copy link
Collaborator Author

It is iOS 17 specific and only on the iPhone.

@kelson42
Copy link
Contributor

@BPerlakiH So, this is working on iPhone with iOS18?

@BPerlakiH
Copy link
Collaborator Author

BPerlakiH commented Aug 11, 2024 •
edited
Loading

I am not sure if it's working on iOS18, maybe it's a bit too early for that, as I do not have iOS 18 installed yet, and currently it's not yet released.
I can have a look via Beta (Xcode 16 Beta, and iOS 18 Beta), but that is only on the simulator, which might not be accurate.

@kelson42
Copy link
Contributor

@BPerlakiH Please do, testing with iPadOS 17 as well.

@BPerlakiH BPerlakiH mentioned this issue Aug 13, 2024
Closed
@BPerlakiH
Copy link
Collaborator Author

BPerlakiH commented Aug 13, 2024 •
edited
Loading

This is iPhone only specific (iPadOS 17 works OK). Also reproducible with the latest ZIM file from: #914

@kelson42
Copy link
Contributor

kelson42 commented Aug 13, 2024 •
edited
Loading

Please share here the table of errors for iPadOS/iOS and iOS17 and 18.. The exact step-by step procedure + screencast are needed.

@kelson42
Copy link
Contributor

@BPerlakiH Split also in teo different issues the autofullscreen issue and the black box issue.

@BPerlakiH
Copy link
Collaborator Author

@kelson42 I have updated my PR, that fixes the black screen issue for all (known to me) content. If we are good to go with that solution, the auto-full screen won't be an issue any more, as it seems to be only content related: Depending only on the content loaded it either goes full screen directly or not, so I am not sure if that needs to be "fixed".

Will have a look on iOS 18 as well...

@BPerlakiH
Copy link
Collaborator Author

Well... iOS 18 is still in beta, so many things are not working.
Eg. this code is crashing:
webView.setValue(view.safeAreaInsets, forKey: "_obscuredInsets")
but even if I take that out, the webm videos are not playing, just spinning and loading:
Screenshot 2024-08-15 at 19 27 00
Screenshot 2024-08-15 at 19 19 15

So it's not helpful at all, once we will have a Golden Master release from Apple, it's worth to re-test.

@BPerlakiH
Copy link
Collaborator Author

BPerlakiH commented Aug 15, 2024 •
edited
Loading

TLDR:
this only affects iOS 17 on the iPhone.
iPad on iOS 17 is OK.

The PR is fixing this issue specifically for iPhone on iOS 17.
iOS 18 is still in beta, and unreliable to compare with.

@kelson42
Copy link
Contributor

This is a very serious bug and considering we have been working since May on these topics, it sounds to me we might face a regression here. openzim/ted#185 should have fixed it.

@rgaudin
Copy link
Member

rgaudin commented Aug 16, 2024 •
edited
Loading

Thank you ; I confirm that as far as I can tell, this is an upstream issue in WKWebView+iOS 17+WebM+iPhone (I only tested on iPhone so I trust you guys on the last condition).

Reprocase is very simple as the following doesn't work. Remove the poster attribute and it works…

<html>
<body>
<video poster="thumbnail.png" src="video.webm" />
</body>
</html>

So let's go with the workaround for now.

@BPerlakiH
Copy link
Collaborator Author

Opened a separate issue for the "auto" full screen issue here: #933

@rgaudin rgaudin mentioned this issue Sep 2, 2024
Open
@benoit74 benoit74 mentioned this issue Oct 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BPerlakiH BPerlakiH

Labels
bug iOS
Projects
None yet
Milestone
3.5.0
Development

Successfully merging a pull request may close this issue.

Fix iPhone video starting with a black screen on iOS 17 iPhone kiwix/kiwix-apple
3 participants
@rgaudin @kelson42 @BPerlakiH