Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space samples and reheat buttons do not work with draw_node() #93

Open
kitchensjn opened this issue Oct 8, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@kitchensjn
Copy link
Owner

Don't know how this slipped through the cracks, but makes sense as draw_node() doesn't differentiate terminal nodes so doesn't know how to evenly position these. This leads to similar problems as #79, so may be worth tackling sooner rather than later.

@kitchensjn kitchensjn added the bug Something isn't working label Oct 8, 2024
@kitchensjn
Copy link
Owner Author

Similarly, there is a lot of bloat in the JSON because evenly_distributed_positions is calculated based on the big ARG, so even if you are only plotting a small subgraph you get a giant array of numbers. This should be instead calculated based on the number of terminal nodes or something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant