Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contents of mutation popup #105

Open
hyanwong opened this issue Nov 7, 2024 · 0 comments
Open

Contents of mutation popup #105

hyanwong opened this issue Nov 7, 2024 · 0 comments

Comments

@hyanwong
Copy link
Contributor

hyanwong commented Nov 7, 2024

@kitchensjn in #103 said:

One thing that I've changed is I've separated the "label" text from the "content" of the popup. This allows for things like the condense mutation labelling scheme (x2, x4, etc). Both of these are generated on draw(), which limits the current customizability. We could store it in the mutations data frame (similarly to the labels for nodes in the nodes data frame). Users could then do customize this to their liking, but this strategy may not play nicely with condense_mutations=True if the user has added a lot of text to the mutation "content" and then all of this text gets merged together into a single popup. I think I'll save this added customizability to mutations for the next release (v0.0.4).

It would indeed be useful to have different "content" strings in the "popup" mutation box / list, which could be longer, e.g. "T->C @ pos 101, 34.2 generations". It's unclear exactly how best to make this flexible, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant