Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: add maintainer file #96

Open
git-bruh opened this issue Sep 1, 2022 · 8 comments
Open

proposal: add maintainer file #96

git-bruh opened this issue Sep 1, 2022 · 8 comments
Labels

Comments

@git-bruh
Copy link
Member

git-bruh commented Sep 1, 2022

A seperate maintainer file is useful as it isn't tied to git history. Most people will be cloning with --depth=1 and the author of the last commit shows up as the maintainer for all packages until another commit is pushed for them.

It also allows running bulk operations like changing sources to use/not use VERSION and possibly auto updating packages

@dilyn-corner
Copy link
Member

Would rather add a line to the build files.

While we're at it, enforcing SPDX license identifiers would be a nice to have.

@sdsddsd1
Copy link

sdsddsd1 commented Sep 1, 2022

Would rather add a line to the build files.

While we're at it, enforcing SPDX license identifiers would be a nice to have.

I second an additional line at the build file. Idk how others feel about the 2nd line being preserved blank. I think it would fit the purpose here. Should be easily parse able.
Adding another file to the package format feels meh, as its violating the format and opens the door for other additional stuff 2.

@illiliti
Copy link
Member

illiliti commented Sep 1, 2022

We have README. I think it's fine place to leave maintainer contacts there.

@dilyn-corner
Copy link
Member

dilyn-corner commented Sep 1, 2022 via email

@illiliti
Copy link
Member

illiliti commented Sep 1, 2022

Unless a package has been contributed via a diff(not a patch) file, no. Anyway, we can always fallback to git.

@apprehensions
Copy link

miscellanous question: since kiss-maintainer gets the maintainer via the package's version file, and say a package was broken and needed a simple fix in the build file and someone submitted a PR, wouldn't the package need its revision bumped? if thats the case then the person who submitted the PR/patch would 'become' the maintainer

@illiliti
Copy link
Member

illiliti commented Sep 7, 2022

That's actually why kiss has policy of maintainer-only updates. Only maintainer can mess with its own packages. I'm not sure if this policy still stands, but that's how things worked before.

@git-bruh
Copy link
Member Author

@kiss-community kiss-community locked and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants