Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing version information in CMake configuration #166

Open
tmadlener opened this issue Nov 22, 2023 · 0 comments · May be fixed by #230
Open

Missing version information in CMake configuration #166

tmadlener opened this issue Nov 22, 2023 · 0 comments · May be fixed by #230
Labels
enhancement New feature or request

Comments

@tmadlener
Copy link
Contributor

tmadlener commented Nov 22, 2023

There is currently no version information set in the cmake config, something like:

# project version
SET( ${PROJECT_NAME}_VERSION_MAJOR X )
SET( ${PROJECT_NAME}_VERSION_MINOR Y )
SET( ${PROJECT_NAME}_VERSION_PATCH Z )

SET( ${PROJECT_NAME}_VERSION  "${${PROJECT_NAME}_VERSION_MAJOR}.${${PROJECT_NAME}_VERSION_MINOR}.${${PROJECT_NAME}_VERSION_PATCH}" )

This makes usage of the tagging script impossible at the moment, and also just makes it hard to use this package downstream in a versioned way.

@tmadlener tmadlener added the enhancement New feature or request label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant