Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the reader from the PodioDataSvc and make the PodioInput populate the internal Frame #105

Open
tmadlener opened this issue May 22, 2023 · 0 comments

Comments

@tmadlener
Copy link
Contributor

Currently, the PodioDataSvc holds a ROOTFrameReader which is used for configuring the input file. On the other hand the collections that should be read are configured via the PodioInput algorithm. All of the input configuration should live in the PodioInput.

Other points to address:

  • Currently all collections have to be stated in the options file. This should become optional to restrict the collections with a default of reading all collections if not stated otherwise.

Food for thought: Could we simply take the default DataHandle from Gaudi and populate it in PodioInput (from the Frame we read there) and take things out again in PodioOutput (put it into a Frame and write things out). Could potentially solve the issues we observe with k4Gen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant