New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several code standards violations #2

Open

Alienpruts opened this issue Nov 23, 2015 · 0 comments

Alienpruts commented Nov 23, 2015

There are several code standards violations scattered around different files

Functions inside classes (methods) should be declared with visibility (ie. public, protected, private).
Single line comments should start with Capital letters and should end with period (.), and be a bit more descriptive.
Indentation violations.
The use of single or double quotes should be consistent (so no mixing of ' and ").

Wherever possible, I will provide patches cleaning things up.

(to be fair, Civicrm Core does not apply those standard either) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment