From d77369a611870b32da930227ea267e400046e38a Mon Sep 17 00:00:00 2001 From: Kevin Papst Date: Fri, 26 Apr 2024 07:45:12 +0200 Subject: [PATCH 1/3] first draft for ux icons support --- README.md | 8 +- assets/tabler-rtl.scss | 1 + assets/tabler.scss | 1 + composer.json | 12 +- config/packages/tabler.yaml | 61 ++- config/services.yml | 14 + src/Command/IconsCommand.php | 831 ++++++++++++++++++++++++++++++++++ src/Twig/IconExtension.php | 52 +++ src/Twig/RuntimeExtension.php | 18 +- src/Twig/TablerExtension.php | 4 +- 10 files changed, 948 insertions(+), 54 deletions(-) create mode 100644 src/Command/IconsCommand.php create mode 100644 src/Twig/IconExtension.php diff --git a/README.md b/README.md index 47a851a..8a9a8bc 100644 --- a/README.md +++ b/README.md @@ -33,7 +33,7 @@ You can check it out here at Github in the [TablerBundle-Demo](https://github.co - ContextHelper for dynamic layout changes (e.g. based on user preferences) - Translations for: english, german, italian, czech, spanish, russian, arabic, finnish, japanese, swedish, portuguese (brazilian), dutch, french, turkish, danish, chinese, slovakian, basque, polish, esperanto, hebrew, romanian ([please help translating it to more languages](https://hosted.weblate.org/projects/kimai/theme/)) - Based on Bootstrap 5 -- Supports FontAwesome 5 +- Supports [Symfony UX icons](https://ux.symfony.com/icons) ## Installation @@ -68,13 +68,15 @@ return [ ]; ``` +Now reload the cache and call `php bin/console tabler:icons`. + ### Step 4: Documentation -Now read what you should do in order to use the theme at [docs/](docs/index.md). +Read how to use the theme at [docs/](docs/index.md). ## License and contributors Published under the MIT, read the [LICENSE](LICENSE) file for more information. -Translations managed with the fantastic [Weblate project](https://hosted.weblate.org/projects/kimai/theme/). +Translations managed with the fantastic [Weblate](https://hosted.weblate.org/projects/kimai/theme/) project. diff --git a/assets/tabler-rtl.scss b/assets/tabler-rtl.scss index dce7c34..b530872 100644 --- a/assets/tabler-rtl.scss +++ b/assets/tabler-rtl.scss @@ -1,6 +1,7 @@ @import '~@tabler/core/dist/css/tabler.rtl.css'; @import '~@tabler/core/dist/css/tabler-vendors.rtl.css'; +// FIXME remove this with the next major update $fa-font-path: "~@fortawesome/fontawesome-free/webfonts/"; @import '~@fortawesome/fontawesome-free/scss/fontawesome'; @import '~@fortawesome/fontawesome-free/scss/regular'; diff --git a/assets/tabler.scss b/assets/tabler.scss index 961b902..53f6d3b 100644 --- a/assets/tabler.scss +++ b/assets/tabler.scss @@ -1,6 +1,7 @@ @import '~@tabler/core/dist/css/tabler.css'; @import '~@tabler/core/dist/css/tabler-vendors.css'; +// FIXME remove this with the next major update $fa-font-path: "~@fortawesome/fontawesome-free/webfonts/"; @import '~@fortawesome/fontawesome-free/scss/fontawesome'; @import '~@fortawesome/fontawesome-free/scss/regular'; diff --git a/composer.json b/composer.json index e25c3df..4b122b9 100644 --- a/composer.json +++ b/composer.json @@ -1,7 +1,7 @@ { "name": "kevinpapst/tabler-bundle", "type": "symfony-bundle", - "description": "Admin/Backend theme bundle for Symfony based on Tabler.io", + "description": "Theme bundle for Symfony based on Tabler.io", "license": "MIT", "authors": [ { @@ -21,6 +21,7 @@ "symfony/security-core": "^6.0 || ^7.0", "symfony/translation": "^6.0 || ^7.0", "symfony/twig-bridge": "^6.0 || ^7.0", + "symfony/ux-icons": "^2.0", "twig/twig": "^3.0" }, "require-dev": { @@ -32,6 +33,15 @@ "phpstan/phpstan-symfony": "^1.0", "knplabs/knp-menu-bundle": "^3.0" }, + "config": { + "platform": { + "php": "8.1.3" + }, + "preferred-install": { + "*": "dist" + }, + "sort-packages": true + }, "suggest" : { "knplabs/knp-menu-bundle" : "Allows easy menu integration" }, diff --git a/config/packages/tabler.yaml b/config/packages/tabler.yaml index 5f55502..484d0e5 100644 --- a/config/packages/tabler.yaml +++ b/config/packages/tabler.yaml @@ -43,36 +43,31 @@ tabler: tabler_password_reset_sent: resetting_send_email icons: - # used for the action_collapsebutton components - collapse: fas fa-chevron-down - # used for the password-reset template - mail: far fa-envelope - # used for the 404/500/... error page - back: fas fa-long-arrow-alt-left - # the following are only ideas to be used in your own templates - about: fas fa-info-circle - admin: fas fa-wrench - bookmark: far fa-star - calendar: far fa-calendar-alt - clock: far fa-clock - comment: far fa-comment - copy: far fa-copy - create: far fa-plus-square - dashboard: fas fa-tachometer-alt - delete: far fa-trash-alt - download: fas fa-download - edit: far fa-edit - email: fa fa-at - export: fas fa-file-export - filter: fas fa-filter - help: far fa-question-circle - home: fas fa-home - password: fas fa-key - phone: fas fa-phone - print: fas fa-print - search: fas fa-search - settings: fas fa-cog - start: fas fa-play - stop: fas fa-stop - upload: fas fa-upload - user: fas fa-user + collapse: "fa6-solid:chevron-down" + mail: "fa6-regular:envelope" + back: "fa6-solid:left-long" + about: "fa6-solid:circle-info" + admin: "fa6-solid:wrench" + bookmark: "fa6-regular:star" + calendar: "fa6-regular:calendar-days" + clock: "fa6-regular:clock" + comment: "fa6-regular:comment" + copy: "fa6-regular:copy" + create: "fa6-regular:square-plus" + dashboard: "fa6-solid:gauge" + delete: "fa6-regular:trash-can" + download: "fa6-solid:download" + edit: "fa6-regular:pen-to-square" + export: "fa6-solid:file-export" + filter: "fa6-solid:filter" + help: "fa6-regular:circle-question" + home: "fa6-solid:house" + password: "fa6-solid:key" + phone: "fa6-solid:phone" + print: "fa6-solid:print" + search: "fa6-solid:magnifying-glass" + settings: "fa6-solid:gear" + start: "fa6-solid:play" + stop: "fa6-solid:stop" + upload: "fa6-solid:upload" + user: "fa6-solid:user" diff --git a/config/services.yml b/config/services.yml index de11908..e1d996a 100644 --- a/config/services.yml +++ b/config/services.yml @@ -1,11 +1,25 @@ services: + KevinPapst\TablerBundle\Command\IconsCommand: + arguments: + - '%kernel.project_dir%' + - '%tabler_bundle.icons%' + tags: + - { name: 'console.command' } + KevinPapst\TablerBundle\Twig\RuntimeExtension: class: KevinPapst\TablerBundle\Twig\RuntimeExtension arguments: - '@event_dispatcher' - '@tabler_bundle.context_helper' - '%tabler_bundle.routes%' + tags: + - { name: twig.runtime } + + KevinPapst\TablerBundle\Twig\IconExtension: + class: KevinPapst\TablerBundle\Twig\IconExtension + arguments: + - '@.ux_icons.icon_renderer' - '%tabler_bundle.icons%' tags: - { name: twig.runtime } diff --git a/src/Command/IconsCommand.php b/src/Command/IconsCommand.php new file mode 100644 index 0000000..8e368ad --- /dev/null +++ b/src/Command/IconsCommand.php @@ -0,0 +1,831 @@ +addOption('overwrite', null, InputOption::VALUE_NONE, 'Overwrite existing icons'); + } + + private function getPackageMappings(): array + { + return [ + 'fas fa-' => 'fa6-solid', + 'far fa-' => 'fa6-regular', + 'fab fa-' => 'fa6-brands', + ]; + } + + private function getIconMapping(): array + { + $result = []; + foreach ($this->tablerBundleIcons as $internal => $external) { + if (str_contains($external, ':')) { + $external = explode(':', $external); + $result[$internal] = [$external[0] => $external[1]]; + continue; + } + foreach ($this->getPackageMappings() as $prefix => $package) { + if (str_starts_with($external, $prefix)) { + $external = str_replace($prefix, '', $external); + $result[$internal] = [$package => $this->rename5To6($external)]; + } + } + } + + return $result; + } + + private function getConvertedConfig(): array + { + $result = []; + foreach ($this->tablerBundleIcons as $internal => $external) { + foreach ($this->getPackageMappings() as $prefix => $package) { + if (str_starts_with($external, $prefix)) { + $external = str_replace($prefix, '', $external); + $result[$internal] = $package . ':' . $this->rename5To6($external); + } + } + } + + return $result; + } + + protected function execute(InputInterface $input, OutputInterface $output): int + { + $io = new SymfonyStyle($input, $output); + + $overwrite = (bool) $input->getOption('overwrite'); + $failures = []; + $iconPath = $this->projectDirectory . '/assets/icons/'; + + try { + $command = $this->getApplication()->find('ux:icons:import'); + foreach ($this->getIconMapping() as $internalName => $packages) { + foreach ($packages as $package => $name) { + if (!$overwrite && file_exists($iconPath . $package . '/' . $name . '.svg')) { + continue; + } + $options = ['names' => [$package . ':' . $name]]; + if (Command::FAILURE === $command->run(new ArrayInput($options), $output)) { + $failures[$internalName] = [$package, $name]; + } + } + } + } catch (Exception $ex) { + $io->error('Failed downloading icon: ' . $ex->getMessage()); + + return Command::FAILURE; + } + + if (\count($failures) > 0) { + $rows = []; + foreach ($failures as $key => $values) { + $rows[] = [ + $key, + $values[0], + $values[1], + 'bin/console ux:icons:search ' . $values[0] . ' ' . $values[1], + ]; + } + + $io->error('Problems downloading the following files'); + $io->table(['Internal', 'Package', 'Name', 'Command'], $rows); + } else { + $io->success('Successful downloaded all icons'); + + $convertedConfig = $this->getConvertedConfig(); + if (\count($convertedConfig) === 0) { + $io->writeln('It seems your config is already up-to-date' . PHP_EOL); + } else { + $io->writeln('Now it is time to convert your configuration, in order to use UX icons.'); + $io->title('New configuration for config/packages/tabler.yaml'); + foreach ($this->getConvertedConfig() as $name => $item) { + $io->writeln($name . ': "' . $item . '"'); + } + } + } + + return Command::SUCCESS; + } + + /** + * See https://docs.fontawesome.com/web/setup/upgrade/whats-changed#icons-renamed-in-version-6 + */ + private function rename5To6(string $name): string + { + return match ($name) { + 'ad' => 'rectangle-ad', + 'adjust' => 'circle-half-stroke', + 'air-freshener' => 'spray-can-sparkles', + 'alien-monster' => 'alien-8bit', + 'allergies' => 'hand-dots', + 'ambulance' => 'truck-medical', + 'american-sign-language-interpreting' => 'hands-asl-interpreting', + 'analytics' => 'chart-mixed', + 'angle-double-down' => 'angles-down', + 'angle-double-left' => 'angles-left', + 'angle-double-right' => 'angles-right', + 'angle-double-up' => 'angles-up', + 'angry' => 'face-angry', + 'apple-alt' => 'apple-whole', + 'apple-crate' => 'crate-apple', + 'archive' => 'box-archive', + 'arrow-alt-circle-down' => 'circle-down', + 'arrow-alt-circle-left' => 'circle-left', + 'arrow-alt-circle-right' => 'circle-right', + 'arrow-alt-circle-up' => 'circle-up', + 'arrow-alt-down' => 'down', + 'arrow-alt-from-bottom' => 'up-from-line', + 'arrow-alt-from-left' => 'right-from-line', + 'arrow-alt-from-right' => 'left-from-line', + 'arrow-alt-from-top' => 'down-from-line', + 'arrow-alt-left' => 'left', + 'arrow-alt-right' => 'right', + 'arrow-alt-square-down' => 'square-down', + 'arrow-alt-square-left' => 'square-left', + 'arrow-alt-square-right' => 'square-right', + 'arrow-alt-square-up' => 'square-up', + 'arrow-alt-to-bottom' => 'down-to-line', + 'arrow-alt-to-left' => 'left-to-line', + 'arrow-alt-to-right' => 'right-to-line', + 'arrow-alt-to-top' => 'up-to-line', + 'arrow-alt-up' => 'up', + 'arrow-circle-down' => 'circle-arrow-down', + 'arrow-circle-left' => 'circle-arrow-left', + 'arrow-circle-right' => 'circle-arrow-right', + 'arrow-circle-up' => 'circle-arrow-up', + 'arrow-from-bottom' => 'arrow-up-from-line', + 'arrow-from-left' => 'arrow-right-from-line', + 'arrow-from-right' => 'arrow-left-from-line', + 'arrow-from-top' => 'arrow-down-from-line', + 'arrow-square-down' => 'square-arrow-down', + 'arrow-square-left' => 'square-arrow-left', + 'arrow-square-right' => 'square-arrow-right', + 'arrow-square-up' => 'square-arrow-up', + 'arrow-to-bottom' => 'arrow-down-to-line', + 'arrow-to-left' => 'arrow-left-to-line', + 'arrow-to-right' => 'arrow-right-to-line', + 'arrow-to-top' => 'arrow-up-to-line', + 'arrows' => 'arrows-up-down-left-right', + 'arrows-alt' => 'up-down-left-right', + 'arrows-alt-h' => 'left-right', + 'arrows-alt-v' => 'up-down', + 'arrows-h' => 'arrows-left-right', + 'arrows-v' => 'arrows-up-down', + 'assistive-listening-systems' => 'ear-listen', + 'atlas' => 'book-atlas', + 'atom-alt' => 'atom-simple', + 'backspace' => 'delete-left', + 'balance-scale' => 'scale-balanced', + 'balance-scale-left' => 'scale-unbalanced', + 'balance-scale-right' => 'scale-unbalanced-flip', + 'band-aid' => 'bandage', + 'barcode-alt' => 'rectangle-barcode', + 'baseball-ball' => 'baseball', + 'basketball-ball' => 'basketball', + 'bed-alt' => 'bed-front', + 'beer' => 'beer-mug-empty', + 'betamax' => 'cassette-betamax', + 'bible' => 'book-bible', + 'biking' => 'person-biking', + 'biking-mountain' => 'person-biking-mountain', + 'birthday-cake' => 'cake-candles', + 'blind' => 'person-walking-with-cane', + 'book-alt' => 'book-blank', + 'book-dead' => 'book-skull', + 'book-reader' => 'book-open-reader', + 'book-spells' => 'book-sparkles', + 'border-style' => 'border-top-left', + 'border-style-alt' => 'border-bottom-right', + 'box-alt' => 'box-taped', + 'box-fragile' => 'square-fragile', + 'box-full' => 'box-open-full', + 'box-up' => 'square-this-way-up', + 'box-usd' => 'box-dollar', + 'boxes' => 'boxes-stacked', + 'boxes-alt' => 'boxes-stacked', + 'brackets' => 'brackets-square', + 'broadcast-tower' => 'tower-broadcast', + 'burn' => 'fire-flame-simple', + 'bus-alt' => 'bus-simple', + 'calculator-alt' => 'calculator-simple', + 'calendar-alt' => 'calendar-days', + 'calendar-edit' => 'calendar-pen', + 'calendar-times' => 'calendar-xmark', + 'camera-alt' => 'camera', + 'camera-home' => 'camera-security', + 'car-alt' => 'car-rear', + 'car-crash' => 'car-burst', + 'car-mechanic' => 'car-wrench', + 'caravan-alt' => 'caravan-simple', + 'caret-circle-down' => 'circle-caret-down', + 'caret-circle-left' => 'circle-caret-left', + 'caret-circle-right' => 'circle-caret-right', + 'caret-circle-up' => 'circle-caret-up', + 'caret-square-down' => 'square-caret-down', + 'caret-square-left' => 'square-caret-left', + 'caret-square-right' => 'square-caret-right', + 'caret-square-up' => 'square-caret-up', + 'cctv' => 'camera-cctv', + 'chalkboard-teacher' => 'chalkboard-user', + 'chart-pie-alt' => 'chart-pie-simple', + 'check-circle' => 'circle-check', + 'check-square' => 'square-check', + 'cheeseburger' => 'burger-cheese', + 'chess-bishop-alt' => 'chess-bishop-piece', + 'chess-clock-alt' => 'chess-clock-flip', + 'chess-king-alt' => 'chess-king-piece', + 'chess-knight-alt' => 'chess-knight-piece', + 'chess-pawn-alt' => 'chess-pawn-piece', + 'chess-queen-alt' => 'chess-queen-piece', + 'chess-rook-alt' => 'chess-rook-piece', + 'chevron-circle-down' => 'circle-chevron-down', + 'chevron-circle-left' => 'circle-chevron-left', + 'chevron-circle-right' => 'circle-chevron-right', + 'chevron-circle-up' => 'circle-chevron-up', + 'chevron-double-down' => 'chevrons-down', + 'chevron-double-left' => 'chevrons-left', + 'chevron-double-right' => 'chevrons-right', + 'chevron-double-up' => 'chevrons-up', + 'chevron-square-down' => 'square-chevron-down', + 'chevron-square-left' => 'square-chevron-left', + 'chevron-square-right' => 'square-chevron-right', + 'chevron-square-up' => 'square-chevron-up', + 'clinic-medical' => 'house-chimney-medical', + 'cloud-download' => 'cloud-arrow-down', + 'cloud-download-alt' => 'cloud-arrow-down', + 'cloud-upload' => 'cloud-arrow-up', + 'cloud-upload-alt' => 'cloud-arrow-up', + 'cocktail' => 'martini-glass-citrus', + 'coffee' => 'mug-saucer', + 'coffee-togo' => 'cup-togo', + 'cog' => 'gear', + 'cogs' => 'gears', + 'columns' => 'table-columns', + 'comment-alt' => 'message', + 'comment-alt-check' => 'message-check', + 'comment-alt-dollar' => 'message-dollar', + 'comment-alt-dots' => 'message-dots', + 'comment-alt-edit' => 'message-pen', + 'comment-alt-exclamation' => 'message-exclamation', + 'comment-alt-lines' => 'message-lines', + 'comment-alt-medical' => 'message-medical', + 'comment-alt-minus' => 'message-minus', + 'comment-alt-music' => 'message-music', + 'comment-alt-plus' => 'message-plus', + 'comment-alt-slash' => 'message-slash', + 'comment-alt-smile' => 'message-smile', + 'comment-alt-times' => 'message-xmark', + 'comment-edit' => 'comment-pen', + 'comment-times' => 'comment-xmark', + 'comments-alt' => 'messages', + 'comments-alt-dollar' => 'messages-dollar', + 'compress-alt' => 'down-left-and-up-right-to-center', + 'compress-arrows-alt' => 'minimize', + 'concierge-bell' => 'bell-concierge', + 'construction' => 'triangle-person-digging', + 'conveyor-belt-alt' => 'conveyor-belt-boxes', + 'cowbell-more' => 'cowbell-circle-plus', + 'cricket' => 'cricket-bat-ball', + 'crop-alt' => 'crop-simple', + 'curling' => 'curling-stone', + 'cut' => 'scissors', + 'deaf' => 'ear-deaf', + 'debug' => 'ban-bug', + 'desktop-alt' => 'desktop', + 'dewpoint' => 'droplet-degree', + 'diagnoses' => 'person-dots-from-line', + 'digging' => 'person-digging', + 'digital-tachograph' => 'tachograph-digital', + 'directions' => 'diamond-turn-right', + 'dizzy' => 'face-dizzy', + 'dolly-flatbed' => 'cart-flatbed', + 'dolly-flatbed-alt' => 'cart-flatbed-boxes', + 'dolly-flatbed-empty' => 'cart-flatbed-empty', + 'donate' => 'circle-dollar-to-slot', + 'dot-circle' => 'circle-dot', + 'drafting-compass' => 'compass-drafting', + 'drone-alt' => 'drone-front', + 'dryer-alt' => 'dryer-heat', + 'eclipse-alt' => 'moon-over-sun', + 'edit' => 'pen-to-square', + 'ellipsis-h' => 'ellipsis', + 'ellipsis-h-alt' => 'ellipsis-stroke', + 'ellipsis-v' => 'ellipsis-vertical', + 'ellipsis-v-alt' => 'ellipsis-stroke-vertical', + 'envelope-square' => 'square-envelope', + 'exchange' => 'arrow-right-arrow-left', + 'exchange-alt' => 'right-left', + 'exclamation-circle' => 'circle-exclamation', + 'exclamation-square' => 'square-exclamation', + 'exclamation-triangle' => 'triangle-exclamation', + 'expand-alt' => 'up-right-and-down-left-from-center', + 'expand-arrows' => 'arrows-maximize', + 'expand-arrows-alt' => 'maximize', + 'external-link' => 'arrow-up-right-from-square', + 'external-link-alt' => 'up-right-from-square', + 'external-link-square' => 'square-arrow-up-right', + 'external-link-square-alt' => 'square-up-right', + 'eyedropper' => 'eye-dropper', + 'fast-backward' => 'backward-fast', + 'fast-forward' => 'forward-fast', + 'feather-alt' => 'feather-pointed', + 'female' => 'person-dress', + 'field-hockey' => 'field-hockey-stick-ball', + 'fighter-jet' => 'jet-fighter', + 'file-alt' => 'file-lines', + 'file-archive' => 'file-zipper', + 'file-chart-line' => 'file-chart-column', + 'file-download' => 'file-arrow-down', + 'file-edit' => 'file-pen', + 'file-medical-alt' => 'file-waveform', + 'file-search' => 'file-magnifying-glass', + 'file-times' => 'file-xmark', + 'file-upload' => 'file-arrow-up', + 'film-alt' => 'film-simple', + 'fire-alt' => 'fire-flame-curved', + 'first-aid' => 'kit-medical', + 'fist-raised' => 'hand-fist', + 'flag-alt' => 'flag-swallowtail', + 'flame' => 'fire-flame', + 'flask-poison' => 'flask-round-poison', + 'flask-potion' => 'flask-round-potion', + 'flushed' => 'face-flushed', + 'fog' => 'cloud-fog', + 'folder-download' => 'folder-arrow-down', + 'folder-times' => 'folder-xmark', + 'folder-upload' => 'folder-arrow-up', + 'font-awesome-alt' => 'square-font-awesome-stroke', + 'font-awesome-flag' => 'font-awesome', + 'font-awesome-logo-full' => 'font-awesome', + 'football-ball' => 'football', + 'fragile' => 'wine-glass-crack', + 'frosty-head' => 'snowman-head', + 'frown' => 'face-frown', + 'frown-open' => 'face-frown-open', + 'funnel-dollar' => 'filter-circle-dollar', + 'game-board-alt' => 'game-board-simple', + 'gamepad-alt' => 'gamepad-modern', + 'glass-champagne' => 'champagne-glass', + 'glass-cheers' => 'champagne-glasses', + 'glass-martini' => 'martini-glass-empty', + 'glass-martini-alt' => 'martini-glass', + 'glass-whiskey' => 'whiskey-glass', + 'glass-whiskey-rocks' => 'whiskey-glass-ice', + 'glasses-alt' => 'glasses-round', + 'globe-africa' => 'earth-africa', + 'globe-americas' => 'earth-americas', + 'globe-asia' => 'earth-asia', + 'globe-europe' => 'earth-europe', + 'golf-ball' => 'golf-ball-tee', + 'grimace' => 'face-grimace', + 'grin' => 'face-grin', + 'grin-alt' => 'face-grin-wide', + 'grin-beam' => 'face-grin-beam', + 'grin-beam-sweat' => 'face-grin-beam-sweat', + 'grin-hearts' => 'face-grin-hearts', + 'grin-squint' => 'face-grin-squint', + 'grin-squint-tears' => 'face-grin-squint-tears', + 'grin-stars' => 'face-grin-stars', + 'grin-tears' => 'face-grin-tears', + 'grin-tongue' => 'face-grin-tongue', + 'grin-tongue-squint' => 'face-grin-tongue-squint', + 'grin-tongue-wink' => 'face-grin-tongue-wink', + 'grin-wink' => 'face-grin-wink', + 'grip-horizontal' => 'grip', + 'h-square' => 'square-h', + 'hamburger' => 'burger', + 'hand-holding-usd' => 'hand-holding-dollar', + 'hand-holding-water' => 'hand-holding-droplet', + 'hand-paper' => 'hand', + 'hand-receiving' => 'hands-holding-diamond', + 'hand-rock' => 'hand-back-fist', + 'hands-heart' => 'hands-holding-heart', + 'hands-helping' => 'handshake-angle', + 'hands-usd' => 'hands-holding-dollar', + 'hands-wash' => 'hands-bubbles', + 'handshake-alt' => 'handshake-simple', + 'handshake-alt-slash' => 'handshake-simple-slash', + 'hard-hat' => 'helmet-safety', + 'hdd' => 'hard-drive', + 'head-vr' => 'head-side-goggles', + 'headphones-alt' => 'headphones-simple', + 'heart-broken' => 'heart-crack', + 'heart-circle' => 'circle-heart', + 'heart-rate' => 'wave-pulse', + 'heart-square' => 'square-heart', + 'heartbeat' => 'heart-pulse', + 'hiking' => 'person-hiking', + 'history' => 'clock-rotate-left', + 'home' => 'house', + 'home-alt' => 'house', + 'home-heart' => 'house-heart', + 'home-lg' => 'house-chimney', + 'home-lg-alt' => 'house', + 'hospital-alt' => 'hospital', + 'hospital-symbol' => 'circle-h', + 'hot-tub' => 'hot-tub-person', + 'hourglass-half' => 'hourglass', + 'house-damage' => 'house-chimney-crack', + 'house-leave' => 'house-person-leave', + 'house-return' => 'house-person-return', + 'hryvnia' => 'hryvnia-sign', + 'humidity' => 'droplet-percent', + 'icons-alt' => 'symbols', + 'id-card-alt' => 'id-card-clip', + 'industry-alt' => 'industry-windows', + 'info-circle' => 'circle-info', + 'info-square' => 'square-info', + 'innosoft' => '42-group', + 'inventory' => 'shelves', + 'journal-whills' => 'book-journal-whills', + 'kiss' => 'face-kiss', + 'kiss-beam' => 'face-kiss-beam', + 'kiss-wink-heart' => 'face-kiss-wink-heart', + 'landmark-alt' => 'landmark-dome', + 'laptop-house' => 'house-laptop', + 'laugh' => 'face-laugh', + 'laugh-beam' => 'face-laugh-beam', + 'laugh-squint' => 'face-laugh-squint', + 'laugh-wink' => 'face-laugh-wink', + 'level-down' => 'arrow-turn-down', + 'level-down-alt' => 'turn-down', + 'level-up' => 'arrow-turn-up', + 'level-up-alt' => 'turn-up', + 'list-alt' => 'rectangle-list', + 'location' => 'location-crosshairs', + 'location-circle' => 'circle-location-arrow', + 'location-slash' => 'location-crosshairs-slash', + 'lock-alt' => 'lock-keyhole', + 'lock-open-alt' => 'lock-keyhole-open', + 'long-arrow-alt-down' => 'down-long', + 'long-arrow-alt-left' => 'left-long', + 'long-arrow-alt-right' => 'right-long', + 'long-arrow-alt-up' => 'up-long', + 'long-arrow-down' => 'arrow-down-long', + 'long-arrow-left' => 'arrow-left-long', + 'long-arrow-right' => 'arrow-right-long', + 'long-arrow-up' => 'arrow-up-long', + 'low-vision' => 'eye-low-vision', + 'luchador' => 'luchador-mask', + 'luggage-cart' => 'cart-flatbed-suitcase', + 'magic' => 'wand-magic', + 'mail-bulk' => 'envelopes-bulk', + 'male' => 'person', + 'map-marked' => 'map-location', + 'map-marked-alt' => 'map-location-dot', + 'map-marker' => 'location-pin', + 'map-marker-alt' => 'location-dot', + 'map-marker-alt-slash' => 'location-dot-slash', + 'map-marker-check' => 'location-check', + 'map-marker-edit' => 'location-pen', + 'map-marker-exclamation' => 'location-exclamation', + 'map-marker-minus' => 'location-minus', + 'map-marker-plus' => 'location-plus', + 'map-marker-question' => 'location-question', + 'map-marker-slash' => 'location-pin-slash', + 'map-marker-smile' => 'location-smile', + 'map-marker-times' => 'location-xmark', + 'map-signs' => 'signs-post', + 'mars-stroke-h' => 'mars-stroke-right', + 'mars-stroke-v' => 'mars-stroke-up', + 'medium-m' => 'medium', + 'medkit' => 'suitcase-medical', + 'meh' => 'face-meh', + 'meh-blank' => 'face-meh-blank', + 'meh-rolling-eyes' => 'face-rolling-eyes', + 'microphone-alt' => 'microphone-lines', + 'microphone-alt-slash' => 'microphone-lines-slash', + 'mind-share' => 'brain-arrow-curved-right', + 'minus-circle' => 'circle-minus', + 'minus-hexagon' => 'hexagon-minus', + 'minus-octagon' => 'octagon-minus', + 'minus-square' => 'square-minus', + 'mobile-alt' => 'mobile-screen-button', + 'mobile-android' => 'mobile', + 'mobile-android-alt' => 'mobile-screen', + 'money-bill-alt' => 'money-bill-1', + 'money-bill-wave-alt' => 'money-bill-1-wave', + 'money-check-alt' => 'money-check-dollar', + 'money-check-edit' => 'money-check-pen', + 'money-check-edit-alt' => 'money-check-dollar-pen', + 'monitor-heart-rate' => 'monitor-waveform', + 'mouse' => 'computer-mouse', + 'mouse-alt' => 'computer-mouse-scrollwheel', + 'mouse-pointer' => 'arrow-pointer', + 'music-alt' => 'music-note', + 'music-alt-slash' => 'music-note-slash', + 'oil-temp' => 'oil-temperature', + 'page-break' => 'file-dashed-line', + 'paint-brush' => 'paintbrush', + 'paint-brush-alt' => 'paintbrush-fine', + 'paint-brush-fine' => 'paintbrush-fine', + 'pallet-alt' => 'pallet-boxes', + 'paragraph-rtl' => 'paragraph-left', + 'parking' => 'square-parking', + 'parking-circle' => 'circle-parking', + 'parking-circle-slash' => 'ban-parking', + 'parking-slash' => 'square-parking-slash', + 'pastafarianism' => 'spaghetti-monster-flying', + 'pause-circle' => 'circle-pause', + 'paw-alt' => 'paw-simple', + 'pen-alt' => 'pen-clip', + 'pen-square' => 'square-pen', + 'pencil-alt' => 'pencil', + 'pencil-paintbrush' => 'pen-paintbrush', + 'pencil-ruler' => 'pen-ruler', + 'pennant' => 'flag-pennant', + 'people-arrows' => 'people-arrows-left-right', + 'people-carry' => 'people-carry-box', + 'percentage' => 'percent', + 'person-carry' => 'person-carry-box', + 'phone-alt' => 'phone-flip', + 'phone-laptop' => 'laptop-mobile', + 'phone-square' => 'square-phone', + 'phone-square-alt' => 'square-phone-flip', + 'photo-video' => 'photo-film', + 'plane-alt' => 'plane-engines', + 'play-circle' => 'circle-play', + 'plus-circle' => 'circle-plus', + 'plus-hexagon' => 'hexagon-plus', + 'plus-octagon' => 'octagon-plus', + 'plus-square' => 'square-plus', + 'poll' => 'square-poll-vertical', + 'poll-h' => 'square-poll-horizontal', + 'portal-enter' => 'person-to-portal', + 'portal-exit' => 'person-from-portal', + 'portrait' => 'image-portrait', + 'pound-sign' => 'sterling-sign', + 'pray' => 'person-praying', + 'praying-hands' => 'hands-praying', + 'prescription-bottle-alt' => 'prescription-bottle-medical', + 'presentation' => 'presentation-screen', + 'print-search' => 'print-magnifying-glass', + 'procedures' => 'bed-pulse', + 'project-diagram' => 'diagram-project', + 'question-circle' => 'circle-question', + 'question-square' => 'square-question', + 'quran' => 'book-quran', + 'rabbit-fast' => 'rabbit-running', + 'radiation-alt' => 'circle-radiation', + 'radio-alt' => 'radio-tuner', + 'random' => 'shuffle', + 'rectangle-landscape' => 'rectangle', + 'rectangle-portrait' => 'rectangle-vertical', + 'redo' => 'arrow-rotate-right', + 'redo-alt' => 'rotate-right', + 'remove-format' => 'text-slash', + 'repeat-1-alt' => 'arrows-repeat-1', + 'repeat-alt' => 'arrows-repeat', + 'retweet-alt' => 'arrows-retweet', + 'rss-square' => 'square-rss', + 'running' => 'person-running', + 'sad-cry' => 'face-sad-cry', + 'sad-tear' => 'face-sad-tear', + 'save' => 'floppy-disk', + 'sax-hot' => 'saxophone-fire', + 'scalpel-path' => 'scalpel-line-dashed', + 'scanner-image' => 'scanner', + 'search' => 'magnifying-glass', + 'search-dollar' => 'magnifying-glass-dollar', + 'search-location' => 'magnifying-glass-location', + 'search-minus' => 'magnifying-glass-minus', + 'search-plus' => 'magnifying-glass-plus', + 'sensor-alert' => 'sensor-triangle-exclamation', + 'sensor-smoke' => 'sensor-cloud', + 'share-alt' => 'share-nodes', + 'share-alt-square' => 'square-share-nodes', + 'share-square' => 'share-from-square', + 'shield-alt' => 'shield-blank', + 'shipping-fast' => 'truck-fast', + 'shipping-timed' => 'truck-clock', + 'shopping-bag' => 'bag-shopping', + 'shopping-basket' => 'basket-shopping', + 'shopping-cart' => 'cart-shopping', + 'shuttle-van' => 'van-shuttle', + 'sign' => 'sign-hanging', + 'sign-in' => 'arrow-right-to-bracket', + 'sign-in-alt' => 'right-to-bracket', + 'sign-language' => 'hands', + 'sign-out' => 'arrow-right-from-bracket', + 'sign-out-alt' => 'right-from-bracket', + 'signal-1' => 'signal-weak', + 'signal-2' => 'signal-fair', + 'signal-3' => 'signal-good', + 'signal-4' => 'signal-strong', + 'signal-alt' => 'signal-bars', + 'signal-alt-1' => 'signal-bars-weak', + 'signal-alt-2' => 'signal-bars-fair', + 'signal-alt-3' => 'signal-bars-good', + 'signal-alt-slash' => 'signal-bars-slash', + 'skating' => 'person-skating', + 'ski-jump' => 'person-ski-jumping', + 'ski-lift' => 'person-ski-lift', + 'skiing' => 'person-skiing', + 'skiing-nordic' => 'person-skiing-nordic', + 'slack-hash' => 'slack', + 'sledding' => 'person-sledding', + 'sliders-h' => 'sliders', + 'sliders-h-square' => 'square-sliders', + 'sliders-v' => 'sliders-up', + 'sliders-v-square' => 'square-sliders-vertical', + 'smile' => 'face-smile', + 'smile-beam' => 'face-smile-beam', + 'smile-plus' => 'face-smile-plus', + 'smile-wink' => 'face-smile-wink', + 'smoking-ban' => 'ban-smoking', + 'sms' => 'comment-sms', + 'snapchat-ghost' => 'snapchat', + 'snowboarding' => 'person-snowboarding', + 'snowmobile' => 'person-snowmobiling', + 'sort-alpha-down' => 'arrow-down-a-z', + 'sort-alpha-down-alt' => 'arrow-down-z-a', + 'sort-alpha-up' => 'arrow-up-a-z', + 'sort-alpha-up-alt' => 'arrow-up-z-a', + 'sort-alt' => 'arrow-down-arrow-up', + 'sort-amount-down' => 'arrow-down-wide-short', + 'sort-amount-down-alt' => 'arrow-down-short-wide', + 'sort-amount-up' => 'arrow-up-wide-short', + 'sort-amount-up-alt' => 'arrow-up-short-wide', + 'sort-circle' => 'circle-sort', + 'sort-circle-down' => 'circle-sort-down', + 'sort-circle-up' => 'circle-sort-up', + 'sort-numeric-down' => 'arrow-down-1-9', + 'sort-numeric-down-alt' => 'arrow-down-9-1', + 'sort-numeric-up' => 'arrow-up-1-9', + 'sort-numeric-up-alt' => 'arrow-up-9-1', + 'sort-shapes-down' => 'arrow-down-triangle-square', + 'sort-shapes-down-alt' => 'arrow-down-square-triangle', + 'sort-shapes-up' => 'arrow-up-triangle-square', + 'sort-shapes-up-alt' => 'arrow-up-square-triangle', + 'sort-size-down' => 'arrow-down-big-small', + 'sort-size-down-alt' => 'arrow-down-small-big', + 'sort-size-up' => 'arrow-up-big-small', + 'sort-size-up-alt' => 'arrow-up-small-big', + 'soup' => 'bowl-hot', + 'space-shuttle' => 'shuttle-space', + 'space-station-moon-alt' => 'space-station-moon-construction', + 'square-root-alt' => 'square-root-variable', + 'star-half-alt' => 'star-half-stroke', + 'starfighter-alt' => 'starfighter-twin-ion-engine', + 'step-backward' => 'backward-step', + 'step-forward' => 'forward-step', + 'sticky-note' => 'note-sticky', + 'stop-circle' => 'circle-stop', + 'store-alt' => 'shop', + 'store-alt-slash' => 'shop-slash', + 'stream' => 'bars-staggered', + 'subway' => 'train-subway', + 'surprise' => 'face-surprise', + 'swimmer' => 'person-swimming', + 'swimming-pool' => 'water-ladder', + 'sync' => 'arrows-rotate', + 'sync-alt' => 'rotate', + 'table-tennis' => 'table-tennis-paddle-ball', + 'tablet-alt' => 'tablet-screen-button', + 'tablet-android' => 'tablet', + 'tablet-android-alt' => 'tablet-screen', + 'tachometer' => 'gauge-simple', + 'tachometer-alt' => 'gauge', + 'tachometer-alt-average' => 'gauge-med', + 'tachometer-alt-fast' => 'gauge', + 'tachometer-alt-fastest' => 'gauge-max', + 'tachometer-alt-slow' => 'gauge-low', + 'tachometer-alt-slowest' => 'gauge-min', + 'tachometer-average' => 'gauge-simple-med', + 'tachometer-fast' => 'gauge-simple', + 'tachometer-fastest' => 'gauge-simple-max', + 'tachometer-slow' => 'gauge-simple-low', + 'tachometer-slowest' => 'gauge-simple-min', + 'tanakh' => 'book-tanakh', + 'tasks' => 'list-check', + 'tasks-alt' => 'bars-progress', + 'telegram-plane' => 'telegram', + 'temperature-down' => 'temperature-arrow-down', + 'temperature-frigid' => 'temperature-snow', + 'temperature-hot' => 'temperature-sun', + 'temperature-up' => 'temperature-arrow-up', + 'tenge' => 'tenge-sign', + 'th' => 'table-cells', + 'th-large' => 'table-cells-large', + 'th-list' => 'table-list', + 'theater-masks' => 'masks-theater', + 'thermometer-empty' => 'temperature-empty', + 'thermometer-full' => 'temperature-full', + 'thermometer-half' => 'temperature-half', + 'thermometer-quarter' => 'temperature-quarter', + 'thermometer-three-quarters' => 'temperature-three-quarters', + 'thumb-tack' => 'thumbtack', + 'thunderstorm' => 'cloud-bolt', + 'thunderstorm-moon' => 'cloud-bolt-moon', + 'thunderstorm-sun' => 'cloud-bolt-sun', + 'ticket-alt' => 'ticket-simple', + 'times' => 'xmark', + 'times-circle' => 'circle-xmark', + 'times-hexagon' => 'hexagon-xmark', + 'times-octagon' => 'octagon-xmark', + 'times-square' => 'square-xmark', + 'tint' => 'droplet', + 'tint-slash' => 'droplet-slash', + 'tired' => 'face-tired', + 'toilet-paper-alt' => 'toilet-paper-blank', + 'tombstone-alt' => 'tombstone-blank', + 'tools' => 'screwdriver-wrench', + 'torah' => 'scroll-torah', + 'tram' => 'train-tram', + 'transgender-alt' => 'transgender', + 'trash-alt' => 'trash-can', + 'trash-restore' => 'trash-arrow-up', + 'trash-restore-alt' => 'trash-can-arrow-up', + 'trash-undo-alt' => 'trash-can-undo', + 'tree-alt' => 'tree-deciduous', + 'triangle-music' => 'triangle-instrument', + 'trophy-alt' => 'trophy-star', + 'truck-couch' => 'truck-ramp-couch', + 'truck-loading' => 'truck-ramp-box', + 'tshirt' => 'shirt', + 'tv-alt' => 'tv', + 'undo' => 'arrow-rotate-left', + 'undo-alt' => 'rotate-left', + 'university' => 'building-columns', + 'unlink' => 'link-slash', + 'unlock-alt' => 'unlock-keyhole', + 'usd-circle' => 'circle-dollar', + 'usd-square' => 'square-dollar', + 'user-alt' => 'user-large', + 'user-alt-slash' => 'user-large-slash', + 'user-chart' => 'chart-user', + 'user-circle' => 'circle-user', + 'user-cog' => 'user-gear', + 'user-edit' => 'user-pen', + 'user-friends' => 'user-group', + 'user-hard-hat' => 'user-helmet-safety', + 'user-md' => 'user-doctor', + 'user-md-chat' => 'user-doctor-message', + 'user-times' => 'user-xmark', + 'users-class' => 'screen-users', + 'users-cog' => 'users-gear', + 'users-crown' => 'user-group-crown', + 'utensil-fork' => 'fork', + 'utensil-knife' => 'knife', + 'utensil-spoon' => 'spoon', + 'utensils-alt' => 'fork-knife', + 'vhs' => 'cassette-vhs', + 'volleyball-ball' => 'volleyball', + 'volume-down' => 'volume-low', + 'volume-mute' => 'volume-xmark', + 'volume-up' => 'volume-high', + 'vote-nay' => 'xmark-to-slot', + 'vote-yea' => 'check-to-slot', + 'walking' => 'person-walking', + 'warehouse-alt' => 'warehouse-full', + 'washer' => 'washing-machine', + 'water-lower' => 'water-arrow-down', + 'water-rise' => 'water-arrow-up', + 'waveform-path' => 'waveform-lines', + 'webcam' => 'camera-web', + 'webcam-slash' => 'camera-web-slash', + 'weight' => 'weight-scale', + 'wifi-1' => 'wifi-weak', + 'wifi-2' => 'wifi-fair', + 'window-alt' => 'window-flip', + 'window-close' => 'rectangle-xmark', + 'wine-glass-alt' => 'wine-glass-empty', + default => $name + }; + } +} diff --git a/src/Twig/IconExtension.php b/src/Twig/IconExtension.php new file mode 100644 index 0000000..becc0cc --- /dev/null +++ b/src/Twig/IconExtension.php @@ -0,0 +1,52 @@ + $icons + */ + public function __construct( + private readonly IconRenderer $iconRenderer, + private readonly array $icons + ) { + } + + public function createIcon(string $name, bool $withIconClass = false, string $default = null): string + { + $icon = $this->getIcon($name, $default); + + if (str_contains($icon, ':')) { + return $this->iconRenderer->renderIcon($icon, ['class' => 'icon']); + } + + @trigger_error('Support for webfonts is deprecated. Switch to UX icons. Using twig function tabler_icon("' . $name . '") is deprecated.', \E_USER_DEPRECATED); + + return ''; + } + + public function icon(string $name, bool $withIconClass = false, string $default = null): string + { + $icon = $this->getIcon($name, $default); + + @trigger_error('Support for webfonts is deprecated. Switch to UX icons. Using Twig filter "' . $name . '"|tabler_icon is deprecated.', \E_USER_DEPRECATED); + + return ($withIconClass ? 'icon ' : '') . $icon; + } + + private function getIcon(string $name, string $default = null): string + { + return $this->icons[str_replace('-', '_', $name)] ?? ($default ?? $name); + } +} diff --git a/src/Twig/RuntimeExtension.php b/src/Twig/RuntimeExtension.php index 35d3f97..43be80b 100644 --- a/src/Twig/RuntimeExtension.php +++ b/src/Twig/RuntimeExtension.php @@ -22,13 +22,11 @@ final class RuntimeExtension implements RuntimeExtensionInterface { /** * @param array $routes - * @param array $icons */ public function __construct( - private EventDispatcherInterface $eventDispatcher, - private ContextHelper $helper, - private array $routes, - private array $icons + private readonly EventDispatcherInterface $eventDispatcher, + private readonly ContextHelper $helper, + private readonly array $routes, ) { } @@ -115,16 +113,6 @@ public function getUserDetails(): ?UserDetailsEvent return $userEvent; } - public function createIcon(string $name, bool $withIconClass = false, string $default = null): string - { - return ''; - } - - public function icon(string $name, bool $withIconClass = false, string $default = null): string - { - return ($withIconClass ? 'icon ' : '') . ($this->icons[str_replace('-', '_', $name)] ?? ($default ?? $name)); - } - public function uniqueId(string $prefix = '', bool $more_entropy = false): string { return uniqid($prefix, $more_entropy); diff --git a/src/Twig/TablerExtension.php b/src/Twig/TablerExtension.php index 6571b24..62175fe 100644 --- a/src/Twig/TablerExtension.php +++ b/src/Twig/TablerExtension.php @@ -24,7 +24,7 @@ public function getFilters(): array new TwigFilter('tabler_container', [RuntimeExtension::class, 'containerClass']), new TwigFilter('tabler_body', [RuntimeExtension::class, 'bodyClass']), new TwigFilter('tabler_route', [RuntimeExtension::class, 'getRouteByAlias']), - new TwigFilter('tabler_icon', [RuntimeExtension::class, 'icon']), + new TwigFilter('tabler_icon', [IconExtension::class, 'icon']), ]; } @@ -35,7 +35,7 @@ public function getFunctions(): array { return [ new TwigFunction('tabler_asset_version', [RuntimeExtension::class, 'assetVersion']), - new TwigFunction('tabler_icon', [RuntimeExtension::class, 'createIcon'], ['is_safe' => ['html']]), + new TwigFunction('tabler_icon', [IconExtension::class, 'createIcon'], ['is_safe' => ['html']]), new TwigFunction('tabler_menu', [RuntimeExtension::class, 'getMenu']), new TwigFunction('tabler_notifications', [RuntimeExtension::class, 'getNotifications']), new TwigFunction('tabler_theme', [RuntimeExtension::class, 'theme']), From b6729427208d2b941c89b277aad013630a384a88 Mon Sep 17 00:00:00 2001 From: Kevin Papst Date: Fri, 26 Apr 2024 07:56:21 +0200 Subject: [PATCH 2/3] re-added comments --- config/packages/tabler.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/config/packages/tabler.yaml b/config/packages/tabler.yaml index 484d0e5..3a9cd9c 100644 --- a/config/packages/tabler.yaml +++ b/config/packages/tabler.yaml @@ -43,9 +43,13 @@ tabler: tabler_password_reset_sent: resetting_send_email icons: + # used for the action_collapsebutton components collapse: "fa6-solid:chevron-down" + # used for the password-reset template mail: "fa6-regular:envelope" + # used for the 404/500/... error page back: "fa6-solid:left-long" + # the following are only ideas to be used in your own templates about: "fa6-solid:circle-info" admin: "fa6-solid:wrench" bookmark: "fa6-regular:star" From 6989cf4dfb75bfd7ca52bca72a8596e44322350a Mon Sep 17 00:00:00 2001 From: Kevin Papst Date: Fri, 26 Apr 2024 08:10:37 +0200 Subject: [PATCH 3/3] codestyle and test --- src/Command/IconsCommand.php | 20 ++++++++++- tests/Twig/IconExtensionTest.php | 51 +++++++++++++++++++++++++++++ tests/Twig/RuntimeExtensionTest.php | 7 +--- 3 files changed, 71 insertions(+), 7 deletions(-) create mode 100644 tests/Twig/IconExtensionTest.php diff --git a/src/Command/IconsCommand.php b/src/Command/IconsCommand.php index 8e368ad..a5d9b09 100644 --- a/src/Command/IconsCommand.php +++ b/src/Command/IconsCommand.php @@ -28,6 +28,9 @@ #[AsCommand(name: 'tabler:icons', description: 'Downloads all configured icons to be used as SVG with Symfony UX icon')] final class IconsCommand extends Command { + /** + * @param array $tablerBundleIcons + */ public function __construct( private readonly string $projectDirectory, private readonly array $tablerBundleIcons @@ -40,6 +43,9 @@ protected function configure(): void $this->addOption('overwrite', null, InputOption::VALUE_NONE, 'Overwrite existing icons'); } + /** + * @return array + */ private function getPackageMappings(): array { return [ @@ -49,6 +55,9 @@ private function getPackageMappings(): array ]; } + /** + * @return array> + */ private function getIconMapping(): array { $result = []; @@ -69,6 +78,9 @@ private function getIconMapping(): array return $result; } + /** + * @return array + */ private function getConvertedConfig(): array { $result = []; @@ -93,7 +105,13 @@ protected function execute(InputInterface $input, OutputInterface $output): int $iconPath = $this->projectDirectory . '/assets/icons/'; try { - $command = $this->getApplication()->find('ux:icons:import'); + $app = $this->getApplication(); + if ($app === null) { + $io->error('Could not load application'); + + return Command::FAILURE; + } + $command = $app->find('ux:icons:import'); foreach ($this->getIconMapping() as $internalName => $packages) { foreach ($packages as $package => $name) { if (!$overwrite && file_exists($iconPath . $package . '/' . $name . '.svg')) { diff --git a/tests/Twig/IconExtensionTest.php b/tests/Twig/IconExtensionTest.php new file mode 100644 index 0000000..cf127e7 --- /dev/null +++ b/tests/Twig/IconExtensionTest.php @@ -0,0 +1,51 @@ + 'fas fa-times', + 'mail' => 'fas fa-envelope', + ]; + + $renderer = new IconRenderer($this->createMock(IconRegistryInterface::class), []); + + return new IconExtension($renderer, $icons); + } + + public function testIcon(): void + { + $sut = $this->getSut(); + $this->assertEquals('test', $sut->icon('test')); + } + + public function testCreateIcon(): void + { + $sut = $this->getSut(); + $this->assertEquals('', $sut->createIcon('foo', true, 'bar')); + } + + public function testCreateIconWithDefault(): void + { + $sut = $this->getSut(); + $this->assertEquals('', $sut->createIcon('foo2', false, 'bar')); + } +} diff --git a/tests/Twig/RuntimeExtensionTest.php b/tests/Twig/RuntimeExtensionTest.php index ec28883..9746af8 100644 --- a/tests/Twig/RuntimeExtensionTest.php +++ b/tests/Twig/RuntimeExtensionTest.php @@ -35,14 +35,9 @@ private function getSut(array $options): RuntimeExtension 'hello' => null, ]; - $icons = [ - 'foo' => 'fas fa-times', - 'mail' => 'fas fa-envelope', - ]; - $dispatcher = new EventDispatcher(); - return new RuntimeExtension($dispatcher, $contextHelper, $routes, $icons); + return new RuntimeExtension($dispatcher, $contextHelper, $routes); } public function testGetRouteByAlias(): void