Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support KNP Menu #75

Open
tacman opened this issue Mar 26, 2022 · 4 comments
Open

Support KNP Menu #75

tacman opened this issue Mar 26, 2022 · 4 comments
Labels
Feature Feature requested Status: Reviewed Has staff reply/investigation

Comments

@tacman
Copy link
Contributor

tacman commented Mar 26, 2022

AdminLTEBundle supported KnpMenu, which was nice. It's a powerful library.

I see that the key for knp_menu support is in the config, but if it's enabled it fails, because knp-menu.yml is missing from the config.

I've added that file, but of course the rendering doesn't work. @kevinpapst , is that something you can bring over from the old bundle? Especially since it looks like we should have vertical menu support soon.

@kevinpapst
Copy link
Owner

If someone wants to provide the code via PR 🎉 I don't mind testing and merging it.
It seems to be a well known and wide spread package...
But I don't use it and have no need for it, so I will not put my time into it.

@cavasinf cavasinf added Status: Reviewed Has staff reply/investigation Feature Feature requested labels May 23, 2022
@cavasinf cavasinf added this to the 1.1 milestone May 23, 2022
@eerison
Copy link

eerison commented Dec 2, 2022

But the question is, can we add this without add knp menu as dependency?

@eerison
Copy link

eerison commented Dec 2, 2022

@kevinpapst
Copy link
Owner

kevinpapst commented Dec 2, 2022

Yes, would go into require-dev

Edit: ups, you were quicker

@kevinpapst kevinpapst removed this from the 1.1 milestone Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature requested Status: Reviewed Has staff reply/investigation
Projects
None yet
Development

No branches or pull requests

4 participants