Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Templating - Missing some "Widget template" from Tabler #28

Open
cavasinf opened this issue Dec 16, 2021 · 3 comments
Open

[Feature] Templating - Missing some "Widget template" from Tabler #28

cavasinf opened this issue Dec 16, 2021 · 3 comments
Labels
Feature Feature requested Status: Reviewed Has staff reply/investigation
Milestone

Comments

@cavasinf
Copy link
Collaborator

When using Symfony FormType and form_row() or form_widget(),

Final input render HTML are not related to Tabler.io template.

First what is input today,
Second what it should be.

image

Update required in templates/layout/form-theme.html.twig and templates/layout/form-theme-horizontal.html.twig

@cavasinf cavasinf added Bug Something isn't working Status: Needs Review Not under investigation labels Dec 16, 2021
@cavasinf cavasinf added this to the 1.0 milestone Dec 16, 2021
@kevinpapst
Copy link
Owner

This is on the linked page:
Bildschirmfoto 2021-12-16 um 16 54 31

I would prefer to use floating inputs.
I have used input groups with icons for a longer time and don't think they are entirely helpful for end-users to understand the field type. Or in other cases there is simply no icon top visualize the meaning of a field.

@kevinpapst kevinpapst removed the Status: Needs Review Not under investigation label Dec 16, 2021
@cavasinf
Copy link
Collaborator Author

Understand,

The one I've showed is more flat/modern.
The one you are using is more comprehensible.

How do you want to handle those different input render ?

  • Let at the current state.
  • Allow dev to choose:
    • From tabler.yml
    • Import other/new template in twig.yaml

@cavasinf cavasinf added the Status: Needs Review Not under investigation label Dec 16, 2021
@kevinpapst
Copy link
Owner

As I said: personally I would prefer to use floating inputs and then remove the icons entirely. But I haven't tested them yet, so I am not sure.

I do use my own form theme in my app, only extending the tabler one. There you can always change the look and feel.
But I am not sure if it is easy right now to customize it in your own blocks.

If you have the wish to change it, please sent a PR and I will look at it. I have no strong opinion on this topic.

@kevinpapst kevinpapst removed the Status: Needs Review Not under investigation label Dec 16, 2021
@cavasinf cavasinf added Feature Feature requested Status: Reviewed Has staff reply/investigation and removed Bug Something isn't working labels Dec 17, 2021
@cavasinf cavasinf changed the title [Templating] Widget template are not from Tabler [Feature] Templating - Missing some "Widget template" from Tabler Dec 17, 2021
@cavasinf cavasinf modified the milestones: 1.0, 1.1 Dec 17, 2021
@kevinpapst kevinpapst modified the milestones: 1.1, 1.0 Oct 4, 2022
@kevinpapst kevinpapst modified the milestones: 1.0, 2.0 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature requested Status: Reviewed Has staff reply/investigation
Projects
None yet
Development

No branches or pull requests

2 participants