Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Twig] File Name convention #131

Open
cavasinf opened this issue Jan 5, 2023 · 1 comment
Open

[Twig] File Name convention #131

cavasinf opened this issue Jan 5, 2023 · 1 comment
Labels
BC Break This will cause BC Break Invalid This doesn't seem right Status: Needs Work Need to be reworked
Milestone
2.0

Comments

@cavasinf
Copy link
Collaborator

cavasinf commented Jan 5, 2023

Big BC BREAK, rename twig file names to snake_case

  • card-vertical-navigation.html.twig to card_navigation_vertical.html.twig
  • card_nav.html.twig to card_navigation.html.twig
  • card_nav_header.html.twig to card_navigation_header.html.twig
  • and more...

milestone 1.0 because this has to be done BEFORE the first "real" release
@cavasinf cavasinf added the Invalid This doesn't seem right label Jan 5, 2023
@cavasinf cavasinf added this to the 1.0 milestone Jan 5, 2023
@kevinpapst
Copy link
Owner

Two of them are only internal, aren't they? Makes the BC "smaller".
We should probably document the file name conventions somewhere as well.

@cavasinf cavasinf added Status: Needs Work Need to be reworked BC Break This will cause BC Break labels Mar 31, 2023
@kevinpapst kevinpapst modified the milestones: 1.0, 2.0 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC Break This will cause BC Break Invalid This doesn't seem right Status: Needs Work Need to be reworked
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@kevinpapst @cavasinf