Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patched values update of controlled fields result into obsolete state #295

Closed
kettanaito opened this issue Oct 9, 2018 · 2 comments
Closed
Labels
Milestone

Comments

@kettanaito
Copy link
Owner

Environment

  • react-advanaced-form: 1.5.0

Prerequisites

Setup a simple form where all fields are controlled. Create a handler that updates the state with another values.

What

Current behavior

Next values are propagated to the components and are displayed correctly in the UI, but their counterpart in field state is obsolete.

Expected behavior

Field value updates (regardless of controlled, or uncontrolled fields) are propagated properly into field state.

Why

#268

@kettanaito kettanaito added the bug label Oct 9, 2018
@kettanaito kettanaito added this to the Bugs milestone Oct 9, 2018
@kettanaito kettanaito changed the title Patched value updates of controlled field result into obsolete state Patched values update of controlled fields result into obsolete state Oct 9, 2018
@kettanaito
Copy link
Owner Author

This should be partially solved by #352 (introducing of patched state updates). Concurrency on a field level will be eliminated, yet the buggy dispatch nature of controlled fields onChange handler will remain due to being invoked in componentWillReceveiProps.

The last part to fix this issue would be #324.

@kettanaito
Copy link
Owner Author

This issue relates to #268 and will be solved by it. No need to duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant