Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support persistent logins (OAuth refresh tokens) #12

Open
kepstin opened this issue Apr 14, 2022 · 0 comments
Open

Support persistent logins (OAuth refresh tokens) #12

kepstin opened this issue Apr 14, 2022 · 0 comments

Comments

@kepstin
Copy link
Owner

kepstin commented Apr 14, 2022

The current behaviour of MagicISRC requires that a user re-authenticate with MusicBrainz when their auth token has expired (or if the session storage in the browser is cleared). This is a few extra clicks in the workflow, so for people who use MagicISRC regularly it would be nice to have MagicISRC remember logins.

Some things to think about:

  • Probably needs some login UI work so I can have a "remember me" option to enable persistent logins
  • Store login information and refresh token in permanent storage rather than session storage
  • When should the token be refreshed? Probably only makes sense to do this on ISRC submit (do I want to do it on initial page load?), but error handling and persisting data for re-login might be tricky.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant