Test/ get available liquidity #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xChqrles
force-pushed
the
test/_get_available_liquidity
branch
from
dcced60
to
490c572
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
+ Coverage 97.79% 97.81% +0.01%
==========================================
Files 11 11
Lines 136 137 +1
==========================================
+ Hits 133 134 +1
Misses 3 3 ☔ View full report in Codecov by Sentry. |
new tests are very similar to available_liquidity tests [CONTRACTS] implement _get_available_liquidity tests keep-starknet-strange#90
leohscl
force-pushed
the
test/_get_available_liquidity
branch
from
5fe6249
to
2eff018
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In test__get_available_liquidity_with_expired_requests, I started to re-implement initiate_liquidity_withdrawal, as I don't have access to it directly with contracts using contract_state_for_testing(). Should I keep going or can I somehow call initiate_liquidity_withdrawal() ?