Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CT-1708 has external schema #1420

Merged
merged 1 commit into from
Nov 20, 2024
Merged

CT-1708 has external schema #1420

merged 1 commit into from
Nov 20, 2024

Conversation

jirkasemmler
Copy link
Contributor

@jirkasemmler jirkasemmler commented Nov 13, 2024 •
edited
Loading

Jira: CT-1708
KBC: https://github.com/keboola/connection/pull/5348

Before asking for review make sure that:

Checklist

  • New client method(s) has tests
  • New client method(s) support branches, or they are listed in BranchAwareClient
  • Apiary file is updated

Release

  • I gave the PR a proper label:
    • major (BC break)
    • minor (new feature)
    • patch (backwards compatible fix)
    • no release (just test changes)

@jirkasemmler jirkasemmler added the no release just test changes label Nov 13, 2024
romanbracinik
romanbracinik approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@romanbracinik romanbracinik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok 🙆‍♂️

@jirkasemmler jirkasemmler force-pushed the jirka-ct-1708-test-hasExternalSchema branch from a10111f to feef325 Compare November 20, 2024 08:39
@romanbracinik romanbracinik merged commit 3b23ca6 into master Nov 20, 2024
4 checks passed
@romanbracinik romanbracinik deleted the jirka-ct-1708-test-hasExternalSchema branch November 20, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanbracinik romanbracinik romanbracinik approved these changes

Assignees
No one assigned
Labels
no release just test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jirkasemmler @romanbracinik