Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Connection from Storage Ex and WR #692

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Conversation

davidesner
Copy link
Contributor

Rename Keboola Connection Storage components to Keboola Storage. Connection is no longer used when talking about the platform...

@hhanova
Copy link
Contributor

hhanova commented Oct 31, 2024

@davidesner The components in the UI are still called this way :-). That's why I did not rename them in the docs when I did the rest.

We shouldn't do this until we remove "Connection" from their names and descriptions in the UI as well. Can you do it, please?

We also need to make the changes in https://help.keboola.com/components/extractors/storage/, https://help.keboola.com/components/writers/storage/, and in the navigation.

Thanks!

@pavel-synek
Copy link
Collaborator

Yes, agreed with @hhanova - we need to push for consistency in our naming convention. I can see it has already been renamed on components.keboola.com, let us clean the rest.

@hhanova
Copy link
Contributor

hhanova commented Nov 1, 2024

It's just that the whole thing (components.keboola.com) is called Create your component for Keboola **Connection** :-)))

@hhanova
Copy link
Contributor

hhanova commented Nov 1, 2024

@davidesner thank you for editing the UI so quickly! I've made changes in the other two docs files and navigation.
You can merge it.

@hhanova hhanova marked this pull request as ready for review November 1, 2024 08:21
@davidesner davidesner merged commit 7a85a0b into main Nov 11, 2024
1 check passed
@davidesner davidesner deleted the remove-connection-keyword branch November 11, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants