Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data apps default secrets #689

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Update data apps default secrets #689

merged 4 commits into from
Oct 31, 2024

Conversation

MonikaFeigler
Copy link
Collaborator

Jira issue(s): PROOF-XXX

Changes:


@MonikaFeigler
Copy link
Collaborator Author

@pepamartinec can you please review my proposed changes? Did I describe it correctly, please? Thank you.

Copy link
Contributor

@pepamartinec pepamartinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Z pohledu usera to asi bude v pohode.

Kdybych chtel byt pintlich, tak pokud by se ta sekce mela jmenovat Default ENV vars, mela by toho obsahovat vic (tech envu je vic, museli bysme si je asi projit, co muze byt zajimavy pro usera). A nebo bych to cely prejmenoval na Access Storage from Data App a trochu podle toho upravil textaci, at je to proste navedeni jednoduse, jak se napojit na Storage (to je konec koncu asi to, co bych jako user v tom navodu hledal)

@MonikaFeigler
Copy link
Collaborator Author

@pepamartinec změnila jsem úvod na toto:

Access Storage from Data App

By default, the Keboola Streamlit Docker image includes two environment variables, which can be easily used to access keboola storage from your application:

Může to tak být?

@MonikaFeigler
Copy link
Collaborator Author

@hhanova can you please check it as well? Thank you.

Copy link
Contributor

@pepamartinec pepamartinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mozna jeste takovy detail

components/data-apps/index.md Outdated Show resolved Hide resolved
@MonikaFeigler MonikaFeigler merged commit 373dcab into main Oct 31, 2024
1 check passed
@MonikaFeigler MonikaFeigler deleted the MonikaFeigler-patch-1 branch October 31, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants