Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: arbitrary runtime script execution #141

Open
soulshake opened this issue Oct 31, 2020 · 1 comment
Open

Feature request: arbitrary runtime script execution #141

soulshake opened this issue Oct 31, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@soulshake
Copy link
Contributor

soulshake commented Oct 31, 2020

Hi, really liking Kubestack so far! 🙏

It would be useful if the kubestack/framework image had a location where arbitrary scripts could be placed, which would then be executed at runtime by the default entrypoint.

This would facilitate running some extra tasks at runtime without needing to override the default entrypoint (and fixing it when that entrypoint changes).

It would enable some nice and lazy thing like, say, authenticating to a cluster in CI (just to illustrate):

FROM kubestack/framework:v0.11.0-beta.0-eks
RUN echo "[ -f $HOME/.kube/config ] || aws eks update-kubeconfig --name platform-apps-us-east-2 --alias woot --region us-east-2" >> /opt/bin/entrypoint.d/cluster-auth.sh \
    && chmod +x /opt/bin/entrypoint.d/cluster-auth.sh

Example of other images using this pattern

  • postgres uses /docker-entrypoint-initdb.d/ as described here
  • nginx uses /docker-entrypoint.d/ as shown here
@pst pst added the enhancement New feature or request label Nov 20, 2020
@pst
Copy link
Member

pst commented Nov 20, 2020

I think this is a valid idea to explore. Hooks seem a common approach to this. We could define points in the entrypoint and have pre- and post- hooks where it makes sense.

@pst pst added the good first issue Good for newcomers label Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants