You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
scale.identity()has an incorrect signature, causing the wrong values to be passed to the Scale constructor:
scale.identity=(s)->newScale(domain,prop,filter).rangedScale// domain, prop, filter should be arguments to identity()
These are just a few of the warnings & errors reported by a linter like JSHint. Most of these are trivial to fix and are pretty silly to see in such a popular third-party library.
The text was updated successfully, but these errors were encountered:
You have a number of leaked globals and typos that could cause issues for other scripts. Any serious third-party library should have basic linting.
Using the popular JSHint tool, I was able to find a number of potentially serious issues:
Circle area calculation is completely wrong due to a typo in path.coffee:
Line.clipToBBox()
references a non-existentlen()
function:scale.identity()
has an incorrect signature, causing the wrong values to be passed to theScale
constructor:These are just a few of the warnings & errors reported by a linter like JSHint. Most of these are trivial to fix and are pretty silly to see in such a popular third-party library.
The text was updated successfully, but these errors were encountered: