Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesnt work when images have html encoded urls #21

Open
jimaek opened this issue Jan 11, 2014 · 2 comments
Open

Doesnt work when images have html encoded urls #21

jimaek opened this issue Jan 11, 2014 · 2 comments

Comments

@jimaek
Copy link

jimaek commented Jan 11, 2014

Thank you for this, its a great plugin.

Example http://jsfiddle.net/3CRx7/686/

In my case my images have spaces in them. Then CloudFlare optimizes the images and replaces the URL with html encoded URLs. So the spaces become %20.
This breaks your plugin.

@roman02
Copy link

roman02 commented Apr 16, 2014

Spaces are in file names, not in images. Don't you have control over file names?

@bondt
Copy link

bondt commented Jan 7, 2015

Wouldn't it be better to make the plugin as universal as possible by changing it? See: https://github.com/bondt/imgLiquid/tree/patch-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants