Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bash sets as a hotfix to prevent user-sessions breaking #560

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Fobhep
Copy link
Contributor

@Fobhep Fobhep commented Nov 29, 2022

  • Please check if the PR fulfills these requirements
  • [ x] The commit messages are descriptive
  • [ x] Tests for the changes have been added (for bug fixes / features)
  • [ x] Docs have been added / updated (for bug fixes / features)
  • [x ] An issue has been created for the pull requests. Some issues might require previous discussion.
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix for Julie Auto-Complete breaks User-Session #557

  • What is the current behavior? (You can also link to an open issue here)
    Prevents bash-script breaking user-sessions

  • What is the new behavior (if this is a feature change)?
    No set flags in bash script until properly reviewed

@cniweb
Copy link

cniweb commented Jan 23, 2023

@purbon can you review, please? We need this bugfix urgently, thanks.

@sverrehu
Copy link
Contributor

sverrehu commented Sep 13, 2023

I agree to this. The file will be sourced, and the set commands will affect the user's shell. Also, the hash-bang line makes little sense for a file that must be sourced and not run directly. I suggest removing the first five lines completely.

Co-authored-by: Sverre H. Huseby <shh+github@thathost.com>
Co-authored-by: Sverre H. Huseby <shh+github@thathost.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants