Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@kadena/pactjs-cli] Automate contracts type regeneration #269

Open
javadkh2 opened this issue May 9, 2023 · 1 comment
Open

[@kadena/pactjs-cli] Automate contracts type regeneration #269

javadkh2 opened this issue May 9, 2023 · 1 comment

Comments

@javadkh2
Copy link
Collaborator

javadkh2 commented May 9, 2023

Is your feature request related to a problem? Please describe.
Contract type regeneration is not automated, which means that developers must regenerate the type definitions individually using the pactjs-cli. For instance, if a developer creates a type, and another developer clones the repo, the latter must also retrieve the contracts and regenerate the type definitions using pactjs-cli again.

Describe the solution you'd like
To address this issue, we can automate the process entirely by maintaining a list of generated types and performing post-install actions. The list of contracts can be included in the package.json file or a custom configuration file like .kadenajs. Then, the contracts and types can be retrieved and regenerated automatically during the post-install stage by referencing this list.
image

Describe alternatives you've considered
An alternative could be accepting an option to specify the destination of the generated type definitions instead of the node_module folder. This would make it easier for users to share the files, as they wouldn’t have to regenerate them individually.

Note
Since implementing this feature would require a change in the workflow for generating types, it's better to schedule it for after the release of version 1.0

@alber70g alber70g added this to the Future milestone May 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

This issue is stale because it is open for 60 days with no activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants