Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart: Adding cleanup.enabled and cleanup.imagePullSecrets #965

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

enrique-ayala
Copy link

@enrique-ayala enrique-ayala commented May 8, 2024

Summary

This PR introduces two new settings to the k8up helm chart:

  • cleanup.enabled: Allows users to enable/disable the cleanup of leftover role bindings and roles from older K8up versions.
  • cleanup.imagePullSecrets: This allows the cleanup job to pull images from private repositories.

Checklist

For Helm Chart changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:chart
  • PR contains the chart label, e.g. chart:k8up
  • Variables are documented in the values.yaml using the format required by Helm-Docs.
  • Chart Version bumped if immediate release after merging is planned
  • I have run make chart-docs
  • Link this PR to related code release or other issues.

@enrique-ayala enrique-ayala requested a review from a team as a code owner May 8, 2024 01:29
@enrique-ayala enrique-ayala requested review from tobru and Kidswiss and removed request for a team May 8, 2024 01:29
@TheBigLee
Copy link
Contributor

TheBigLee commented May 28, 2024

@enrique-ayala
Thanks for this PR.

Please run make chart-docs and commit the change. This should fix the ChartLint check.
Furthermore ensure that the commits are all signed to ensure the DCO check passes.

Cheers Nicolas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants