Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub does not detect license in forks? #2

Open
Kwpolska opened this issue Jun 11, 2017 · 4 comments
Open

GitHub does not detect license in forks? #2

Kwpolska opened this issue Jun 11, 2017 · 4 comments

Comments

@Kwpolska
Copy link

This repo has a LICENSE file, and GitHub detects it as MIT. This fork of mine has no license according to GitHub, even though the LICENSE file is the same in both. Perhaps the site should ignore forks altogether?

@k-nut
Copy link
Owner

k-nut commented Jun 11, 2017

Very interesting, I did not notice this while testing. It seems to me like github never shows or exposes the license in the api for forks.

So I think it would be interesting to find out why that is but maybe for the time being we should indeed filter out all the forks.

Feel free to send a pull request that implements this. It should be possible by adding a .filter here.

If you don't have time for this I can just do it myself also.

@Kwpolska
Copy link
Author

Not a fan of JS, so I won’t try to fix this — could you please do it yourself?

@k-nut
Copy link
Owner

k-nut commented Jun 12, 2017

I had another look at this and found that github sometimes does find the license in forks such as in this repo: https://github.com/k-nut/werkzeug

I sent a support request to GitHub and will wait for their feedback on this.

If they do not get back to me within a week I will take out the forks for now.

k-nut added a commit that referenced this issue Jun 12, 2017
@k-nut
Copy link
Owner

k-nut commented Jun 12, 2017

I got feedback from GitHub already: They confirm that this currently is a problem and say that they are working on solving it. Unfortunately they could not give an ETA for this.

I added a disclaimer to the app but will leave this story open until the actual issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants