Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable density for firn layer enhancement #112

Open
jzmejia opened this issue Mar 29, 2024 · 4 comments · Fixed by #113
Open

Variable density for firn layer enhancement #112

jzmejia opened this issue Mar 29, 2024 · 4 comments · Fixed by #113
Assignees

Comments

@jzmejia
Copy link
Owner

jzmejia commented Mar 29, 2024

Issue identified after including depth dependent density functionality to Crevasse class, features added in commits: #111 #110

Crevasse evolution with variable density is producing crevasse shapes like below where they are very bloated at the base, narrowing towards the surface. These crevasses are too wide at the base
Screenshot 2024-03-29 at 7 40 39 PM
crevasse width (m) for 51 model runs

Is the problem in the d equation used to calculate wall displacement not able to support densities other than that of solid ice?

@jzmejia jzmejia added the bug Something isn't working label Mar 29, 2024
@jzmejia jzmejia self-assigned this Mar 29, 2024
@jzmejia jzmejia reopened this Apr 2, 2024
@jzmejia
Copy link
Owner Author

jzmejia commented Apr 2, 2024

Reopening first issue was resolved but a larger problem identified for unstable solutions (mathematical problem)

Depth-variable formation for the second component of the stress intensity factor KI(2) is invalid/unstable for large depths. Need to change implementation/reformulate equations

IMPORTANT: Problem in mathematics applied for solving linear elastic fracture mechanics, not in the code
image

@jzmejia jzmejia removed the bug Something isn't working label Apr 2, 2024
@jzmejia
Copy link
Owner Author

jzmejia commented Apr 2, 2024

comparison between stable formulation (van der veen 2002) vs unstable formulation at large depths (van der veen 1998)

Screenshot 2024-04-02 at 5 03 41 PM

@jzmejia jzmejia added bug Something isn't working formulation and removed bug Something isn't working labels Apr 2, 2024
@jzmejia
Copy link
Owner Author

jzmejia commented Apr 8, 2024

Fix to problem:

  1. Find intersection between constant density and variable density KI(2) solutions.
    Crevasse.threshold
  2. Use Crevasse.threshold to parse KI(2) solutions such that at depths less than threshold the variable density solution is used and at values greater than or equal to threshold the constant density solution is used.

@jzmejia
Copy link
Owner Author

jzmejia commented Apr 9, 2024

density was manually changed inside of some function and density was filled with 917 below a value. Find this and remove it so that the crevasse wall doesn't have a little malformity at that depth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant