Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check fixes/improvements #687

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Conversation

jdpurcell
Copy link
Contributor

  • aa03cf0 uncommented the flag to disable update check support, I'm assuming that was for testing and not intentionally committed.
  • When fetching from the API, it requested the full release list. This caused unnecessary network traffic and would notify for pre-release versions. Now it asks just for the latest version.
  • Changelog was displayed different on macOS vs Windows. This is because the changelog from the API uses \r\n as newline, whereas the splitting happened on \n, leaving \r still present. On macOS the notification dialog looked fine and had newlines, but this wasn't the case on Windows (see screenshots for before/after).
  • Implement rate limiting for the automatic checks at startup, so it doesn't happen more frequently than every 4 hours.

before

after

@jurplel jurplel merged commit 3b96bd3 into jurplel:master Jun 4, 2024
6 checks passed
@jurplel
Copy link
Owner

jurplel commented Jun 4, 2024

thanks! will get to more asap

@jdpurcell jdpurcell deleted the updatechecker branch June 4, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants