Configurable window positioning behavior after matching image size #616
Conversation
| @@ -64,6 +64,7 @@ QVOptionsDialog::QVOptionsDialog(QWidget *parent) : | |||
| #endif | |||
|
|
|||
| syncSettings(false, true); | |||
| connect(ui->windowResizeComboBox, QOverload<int>::of(&QComboBox::currentIndexChanged), this, &QVOptionsDialog::windowResizeComboBoxCurrentIndexChanged); | |||
There was a problem hiding this comment.
Fixed a bug in the existing code where this never got connected up.
|
My main concern with this is the UX. It's a pretty confusing option. More direct language might help--but after revisiting this issue I am questioning if anyone is actually going to use this option. Unfortunately I don't remember my original motivation for the issue, but maybe this needs a rethink. If we have an options cleanup with more tabs and stuff, this option should/could certainly exist, but right now the settings dialog is getting cluttered. |
|
@jurplel No worries, if you want we could close this for now and I could make a new pull request if you like the part with the |
|
Yes, I think that'd be great for now. Thanks! |
Implements #487.