-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Options independent of any profile #802
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
The options set directly on KubeSpawner should already be inherited by all the profiles. Can you give us an example of your desired configuration? |
As I understand it, setting options directly on KubeSpawner allows a static configuration, which is modified by the selected profile and further customizable by the user using |
Proposed change
It would be nice if we could define options that are independent of any profile. If profiles are defined, these options should apply to all profiles.
Alternative options
If profiles are not needed and only independent options are desired, a somewhat ugly workaround would be to have a single profile and define the options there. If both profiles and independent options are needed, the only solution is to duplicate the "independent" options into each profile.
Who would use this feature?
Admins that want to give users more fine-grained control over spawn options, e.g. independent settings for CPU limit, image, etc.
Suggest a solution
Mostly duplicating the functionality of
profile_options
to work without a profile, possiblyoption_list
that is either aDict
of the same format asprofile_options
or a callable that returns such aDict
options_from_form
to accept these optionsload_user_options
to apply the overrides in the same way asprofile_options
are appliedIf you agree that this is a desirable feature and I haven't overlooked anything, I'd be happy to attempt a PR :)
The text was updated successfully, but these errors were encountered: