Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Changed By NSE to nsearchives.nseindia.com Please Update this ASAP. #56

Open
silenThunderr opened this issue Oct 29, 2023 · 2 comments

Comments

@silenThunderr
Copy link

silenThunderr commented Oct 29, 2023

https://github.com/jugaad-py/jugaad-data/blame/c6a6427dc8041ef26c086690c85c46f2d83dcf2a/jugaad_data/nse/archives.py#L25C5-L25C47

New Base URL to be updates is : https://nsearchives.nseindia.com/

class NSEArchives:

class NSEArchives:
base_url = "https://archives.nseindia.com"
"""Conventions

@silenThunderr silenThunderr changed the title URL Changed By NSE to New Please Update this ASAP. URL Changed By NSE to nsearchives.nseindia.com Please Update this ASAP. Oct 29, 2023
pallasite99 added a commit to pallasite99/jugaad-data that referenced this issue Nov 2, 2023
* updated archive.py base URL to point towards new NSE archives URL
@pallasite99
Copy link
Contributor

@silenThunderr I have made the changes here: #57

Although I am not sure how to test this locally hence relying on your original ticket description for scope of changes.

@pallasite99
Copy link
Contributor

pallasite99 commented Nov 2, 2023

@sevakram PTAL when possible, thanks.

Although I am not able to access either URL provided in the ticket (the existing one in codebase and the new one)

sevakram added a commit that referenced this issue Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants